Permalink
Switch branches/tags
Nothing to show
Commits on Aug 26, 2013
  1. Rewrite package paths.

    cmars committed Aug 26, 2013
  2. openpgp/packet: Parse and serialize ECC key material (RFC 6637).

    cmars committed Aug 26, 2013
    	Support ECDSA signature verification.
  3. openpgp/packet: Add support for V3 public keys and signatures.

    cmars committed Aug 26, 2013
    	My goal here was to allow read-only access to legacy key
    material without
    	allowing the user of the API to create new V3 keys or
    signatures.
    
    	My old opaque parser test actually relied on v3 packets not
    being
    	supported, so I had to mangle key material for a similar
    testcase.
  4. openpgp/packet: Add user attribute packet support.

    cmars committed Aug 26, 2013
    	Supports JPEG images as well as free-form arbitrary
    	subpacket data in user attributes (RFC 4880, Section 5.12)
Commits on Aug 15, 2013
  1. openpgp: Implement compressed data packets & add support for compress…

    marete committed Aug 15, 2013
    …ing data during symmetric encryption.
    
    This patch implements the facilities needed to compress data before
    encryption as allowed (and recommended) by RFC 4880. The new
    functionality is then used to add support for compressing data during
    symmetric encryption (openpgp.SymmetricallyEncrypt()).
    
    For now, compression defaults to off. Also, only the ZIP and ZLIB
    compression schemes are supported by this patch.
    
    Resulting output tested/verified using GPG.
    
    https://gist.github.com/marete/6189760 is a small program that can be
    used to test that the output of various compression/encryption settings
    can be read by GPG or other RFC 4880 programs.
    
    Upon review, I will follow this patch with 2 others: a) Add support for 	compression during public key encryption (openpgp.Encrypt()) b) Enable
    compression by default (subject to the restrictions of the "Compression 	Preferences" section in RFC 4880).
    
    R=golang-dev, agl
    CC=golang-dev
    https://codereview.appspot.com/12685044
    
    Committer: Adam Langley <agl@golang.org>
Commits on Aug 5, 2013
  1. go.crypto/openpgp: test that hashes are compiled in before using them.

    agl committed Aug 5, 2013
    Previously, if Encrypt decided to use a hash function that wasn't
    compiled in then it would panic.
    
    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/12055043
Commits on Jul 29, 2013
  1. go.crypto/ocsp: pass in the issuing certificate.

    agl committed Jul 29, 2013
    Paul van Brouwershaven pointed out that it would be better to pass in
    the issuing certificate and have the verification be done in the OCSP
    package than to expect the caller to deal with the difference between
    responses with and without a responder certificate.
    
    R=golang-dev, dayveday, paul
    CC=golang-dev
    https://codereview.appspot.com/11220043
  2. go.crypto/ssh: seed random generator, so auto port allocation is trul…

    hanwen committed Jul 29, 2013
    …y random.
    
    R=agl, dave
    CC=golang-dev
    https://codereview.appspot.com/12027043
    
    Committer: Adam Langley <agl@golang.org>
Commits on Jul 26, 2013
  1. go.crypto/ssh: add workaround for broken port forwarding in

    hanwen committed Jul 26, 2013
    OpenSSH 5.
    
    Tested with OpenSSH_5.9
    
    R=agl, dave
    CC=golang-dev
    https://codereview.appspot.com/11921043
    
    Committer: Adam Langley <agl@golang.org>
Commits on Jul 22, 2013
  1. go.crypto/openpgp: don't select expired keys.

    agl committed Jul 22, 2013
    When selecting keys for encryption, don't select keys that have
    expired.
    
    Fixes issue 5808.
    
    R=bradfitz
    CC=golang-dev
    https://codereview.appspot.com/10847043
  2. go.crypto/ssh: close channel feeding tcpListener.

    hanwen committed Jul 22, 2013
    Close both on closing the listener, and on closing the
    connection. Test the former case.
    
    R=dave
    CC=golang-dev
    https://codereview.appspot.com/11349043
    
    Committer: Dave Cheney <dave@cheney.net>
Commits on Jul 16, 2013
  1. go.crypto/salsa: fix typo in comment and move TODO out of package com…

    agl committed Jul 16, 2013
    …ment.
    
    Thanks to Frithjof Schulze for noticing.
    
    R=goland-dev, r
    CC=golang-dev
    https://codereview.appspot.com/11033044
Commits on Jul 15, 2013
  1. go.crypto/ssh/terminal: support Go 1.0.

    agl committed Jul 15, 2013
    For those still stuck on Go 1.0.
    
    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/11297043
Commits on Jul 3, 2013
  1. openpgp: Add support for BZIP2-compressed data packets.

    marete committed Jul 3, 2013
    Tested using a variety of files encrypted with gpg and the
    "--compress-algo BZIP2" gpg option.
    
    R=golang-dev, bradfitz, agl
    CC=golang-dev
    https://codereview.appspot.com/10801043
    
    Committer: Adam Langley <agl@golang.org>
Commits on Jul 2, 2013
  1. go.crypto/ssh/terminal: don't save passwords in history.

    agl committed Jul 2, 2013
    The history buffer would recall previously entered lines: including passwords. With this change, lines entered while echo is disabled are no longer put into the history.
    
    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/10853043
Commits on Jun 21, 2013
  1. go.crypto/ssh: add hook for host key checking.

    hanwen committed Jun 21, 2013
    R=dave, agl
    CC=gobot, golang-dev
    https://codereview.appspot.com/9922043
    
    Committer: Adam Langley <agl@golang.org>
Commits on Jun 20, 2013
  1. go.crypto/ocsp: allow cert-less responses and support making requests.

    agl committed Jun 20, 2013
    Some OCSP responses (notably COMODO's) don't use an intermediate
    certificate to sign OCSP responses so this change allowed that.
    
    Additionally, a CreateRequest function is added for creating OCSP
    requests.
    
    This change makes one API change: SerialNumber becomes a *big.Int to
    match crypto/x509. The original code dates to before encoding/asn1
    could cope with big.Ints and using a []byte was a workaround for that.
    
    R=golang-dev
    CC=golang-dev
    https://codereview.appspot.com/10402043
Commits on Jun 18, 2013
  1. go.crypto/ssh: fix test breakages introduced by 125:40246d2ae2eb

    hanwen committed Jun 18, 2013
    * Remove special handling for dynamically allocated
      ports. This was a bug in OpenSSH 5.x sshd.
    
    * Run the test with a preselected port number.
    
    * Run TestPortForward only on unix platforms.
    
    R=dave, agl
    CC=golang-dev
    https://codereview.appspot.com/10049045
    
    Committer: Adam Langley <agl@golang.org>
  2. go.crypto/ssh/test: Run sshd with -e, so the debug output goes onto s…

    hanwen committed Jun 18, 2013
    …tderr.
    
    R=dave, agl
    CC=golang-dev
    https://codereview.appspot.com/10230043
    
    Committer: Dave Cheney <dave@cheney.net>
Commits on Jun 12, 2013
  1. go.crypto/ssh: fix and test port forwarding.

    hanwen committed Jun 12, 2013
    Set maxPacket in forwarded connection, and use the requested port
    number as key in forwardList.
    
    R=golang-dev, agl, dave
    CC=golang-dev
    https://codereview.appspot.com/9753044
    
    Committer: Dave Cheney <dave@cheney.net>
Commits on Jun 10, 2013
  1. go.crypto/nacl/secretbox: fix append behaviour.

    agl committed Jun 10, 2013
    secretbox is supposed to append to the given slice, like hash.Sum() and
    append(). However, I had a complete brain-fart: I've really no idea what
    I was thinking of at the time.
    
    R=golang-dev, sfrithjof, rsc
    CC=agl, golang-dev
    https://codereview.appspot.com/10099043
  2. go.crypto: revert 7f5a59ff6b43.

    agl committed Jun 10, 2013
    This change reverts https://codereview.appspot.com/10113043/ because
    some folks are stuck on 1.0 till 1.1.1 comes out.
    
    R=golang-dev
    CC=golang-dev
    https://codereview.appspot.com/10151043
Commits on Jun 7, 2013
  1. go.crypto: remove unreachable code.

    agl committed Jun 7, 2013
    I ran go vet over all of go.crypto and removed lots of panic("unreachable") that are no longer needed.
    
    R=golang-dev, r, dgryski
    CC=golang-dev
    https://codereview.appspot.com/10113043
  2. ssh/terminal: support home, end, up and down keys.

    agl committed Jun 7, 2013
    R=golang-dev, dave
    CC=golang-dev
    https://codereview.appspot.com/9777043
Commits on Jun 6, 2013
  1. go.crypto/ssh: implement keyboard-interactive auth (RFC 4256), both

    hanwen committed Jun 6, 2013
    on client and server-side.
    
    R=dave, agl
    CC=gobot, golang-dev
    https://codereview.appspot.com/9853050
    
    Committer: Adam Langley <agl@golang.org>
  2. go.crypto/ssh: add a error return to decode(), and avoid casting deco…

    hanwen committed Jun 6, 2013
    …de() output.
    
    R=dave, kardianos, agl
    CC=gobot, golang-dev
    https://codereview.appspot.com/9738053
    
    Committer: Adam Langley <agl@golang.org>
Commits on Jun 5, 2013
  1. go.crypto/ssh: fix race on mock ssh network connection

    davecheney committed Jun 5, 2013
    Fixes issue 5138.
    Fixes issue 4703.
    
    This appears to pass my stress tests with and without the -race detector, but I'd like to see others hit it with their machines.
    
    R=golang-dev, fullung, huin, kardianos, agl
    CC=golang-dev
    https://codereview.appspot.com/9929043
Commits on Jun 1, 2013
  1. go.crypto/ssh: fix test breakage

    davecheney committed Jun 1, 2013
    Followup CL for 9711043. The order that CombinedOutput returns data captured from stdout/stderr is not specified, so we have to test both variants.
    
    Thanks to fullung for the bug report.
    
    R=fullung, kr
    CC=golang-dev
    https://codereview.appspot.com/9921044
Commits on May 29, 2013
  1. ssh: add Output and CombinedOutput helpers

    kr committed May 29, 2013
    R=golang-dev, dave
    CC=golang-dev
    https://codereview.appspot.com/9711043
    
    Committer: Dave Cheney <dave@cheney.net>
Commits on Apr 25, 2013
  1. go.crypto/ssh: More error reporting improvements.

    dsymonds committed Apr 25, 2013
    R=golang-dev, kardianos, dave
    CC=golang-dev
    https://codereview.appspot.com/8596047
Commits on Apr 23, 2013
  1. go.crypto/ssh/test: Replace FailNow with Fail where it is obvious tha…

    dsymonds committed Apr 23, 2013
    …t the test doesn't want to fail now.
    
    Improve a couple of test error messages too.
    
    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/8661045
Commits on Apr 17, 2013
  1. go.crypto/ssh/test: Fix distracting nil pointer dereference in a test.

    dsymonds committed Apr 17, 2013
    If cgo is disabled (such as it appears to be on a subset of builders),
    username() panics, and s.cmd is nil; let's not panic while recovering
    from a different panic.
    
    R=golang-dev, dave
    CC=golang-dev
    https://codereview.appspot.com/8820043