Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XH 1.7: NOTICE: Undefined index: show_heading #33

Closed
cmb69 opened this issue Nov 14, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@cmb69
Copy link
Owner

commented Nov 14, 2017

$pageData['show_heading has been removed as of CMSimple_XH 1.7, so the unconditional test is erroneous. Actually, the whole method ::replaceAlternativeHeading() doesn't make sense under CMSimple_XH 1.7.

@cmb69 cmb69 added the bug label Nov 14, 2017

@cmb69 cmb69 added this to the 1.0beta3 milestone Nov 14, 2017

@lck-git

This comment has been minimized.

Copy link

commented Feb 14, 2018

Gibt es dafür schon einen Quick-Fix?

@cmb69

This comment has been minimized.

Copy link
Owner Author

commented Feb 19, 2018

Man könnte wohl diese Zeile durch folgende ersetzen:

        if (isset($pageData['show_heading']) && $pageData['show_heading'] == '1') {
@lck-git

This comment has been minimized.

Copy link

commented Feb 19, 2018

Sehr schön, danke. Damit verschwindet die Notice.

@cmb69 cmb69 closed this in 1b01355 Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.