New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional modifications to CMSimple_XH are bad #6

Closed
cmb69 opened this Issue Mar 19, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@cmb69
Owner

cmb69 commented Mar 19, 2017

In a few cases we have to modify CMSimple_XH to be able to work with the limitations of PHP's built-in webserver. Currently, only XH_isAccessProtected is affected, but other changes might be required in future CMSimple_XH versions.

These modification should never be unconditionally, since users might prepare a website on Portable_XH and later upload the website to a public server, in which case the access protection check would yield potentially wrong results. Instead it should be checked whether the cli-server is in use, and whether the server name is localhost, and only then execute modified code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment