Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Visual Studio Code (cmd) #1416

Merged
merged 1 commit into from Nov 29, 2017
Merged

Conversation

@gucong3000
Copy link
Contributor

gucong3000 commented Jun 23, 2017

image

@gucong3000 gucong3000 changed the title Compatible with Visual Studio Code Compatible with Visual Studio Code (cmd) Jun 23, 2017
@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Jun 23, 2017

config.json of vscode

{
    "terminal.integrated.shell.windows": "cmd.exe",
    "terminal.integrated.shellArgs.windows": [
        "/k",
        "D:\\Program Files\\cmder\\vendor\\init.bat"
    ]
}
@Stanzilla

This comment has been minimized.

Copy link
Member

Stanzilla commented Jul 15, 2017

Can you explain why this is needed, please?

@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Jul 15, 2017

Without is PR, vscode can not use cmder.

@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Jul 15, 2017

And it will work for other IDEs.

@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Aug 3, 2017

Copy link
Member

MartiUK left a comment

LGTM 👍

@Stanzilla Stanzilla requested a review from daxgames Oct 29, 2017
@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Nov 28, 2017

What can I do for help?

@MartiUK MartiUK merged commit ee4f85d into cmderdev:master Nov 29, 2017
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@gucong3000 gucong3000 deleted the gucong3000:patch-1 branch Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.