Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Visual Studio Code (PowerShell) #1417

Merged
merged 2 commits into from Oct 31, 2017

Conversation

@gucong3000
Copy link
Contributor

gucong3000 commented Jun 23, 2017

image

@gucong3000

This comment has been minimized.

Copy link
Contributor Author

gucong3000 commented Jun 23, 2017

config.json of vscode

{
    "terminal.integrated.shell.windows": "powershell.exe",
    "terminal.integrated.shellArgs.windows": [
        "-ExecutionPolicy",
        "Bypass",
        "-NoLogo",
        "-NoProfile",
        "-NoExit",
        "-Command",
        "Invoke-Expression '. ''D:\\Program Files\\cmder\\vendor\\profile.ps1'''"
    ]
}
@Stanzilla

This comment has been minimized.

Copy link
Member

Stanzilla commented Jul 15, 2017

Hey sorry about that, but this has conflicts now

刘祺
# Conflicts:
#	vendor/profile.ps1
Copy link
Member

MartiUK left a comment

LGTM 👍

@Stanzilla Stanzilla requested a review from Jackbennett Oct 29, 2017
@Jackbennett

This comment has been minimized.

Copy link
Contributor

Jackbennett commented Oct 31, 2017

Tested it on my vscode 1.17.2 and it works fine.

Adding a note, VScode defaults to powershell these days and personally my systems have the execution policy as remotesigned so I only need;

"terminal.integrated.shellArgs.windows": [
    "-noExit",
    "-command",
    "invoke-expression '. ''C:\\f\\src\\cmder\\vendor\\profile.ps1'''"
  ]

The string has strange escaping.

@Jackbennett Jackbennett merged commit 7479d62 into cmderdev:master Oct 31, 2017
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@gucong3000 gucong3000 deleted the gucong3000:patch-2 branch Nov 1, 2017
@ShaoqiangLu

This comment has been minimized.

Copy link

ShaoqiangLu commented Nov 28, 2017

  • Anyone can help? This folder has a .git subfolder.
    image
    The warning is as follows
Missing git support, install posh-git with 'Install-Module posh-git' and restart cmder.
  • When I open a folder without a .git subfolder using vscode, everything is OK.
    image
    But if I cd into the git folder, it seems that cmder can't find post-install.bat?
    image

  • I think this may help on stackoverflow.

  • my config.json of vscode

    "terminal.integrated.shell.windows": "powershell.exe",
    "terminal.integrated.shellArgs.windows": [
        "-ExecutionPolicy",
        "Bypass",
        "-NoLogo",
        "-NoProfile",
        "-NoExit",
        "-Command",
        "Invoke-Expression '. ''D:\\Cmder\\vendor\\profile.ps1'''"
    ]
@ShaoqiangLu

This comment has been minimized.

Copy link

ShaoqiangLu commented Nov 28, 2017

@gucong3000 thank you, that works.
I have installed posh-git and everything works well.

@Dream4ever

This comment has been minimized.

Copy link

Dream4ever commented Dec 22, 2017

@gucong3000 Thank you very much, using posh-git and working very well in vscode!
Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.