Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance enhance_path_recursive #2311

Merged
merged 8 commits into from Jun 26, 2020

Conversation

daxgames
Copy link
Member

@daxgames daxgames commented Apr 29, 2020

Reasons for these changes

I am using Cmder for the first time for a job where I am working from unfamiliar territory, a Windows VM. It's an opportunity to use Cmder in many ways using other tools others users have and I am embracing it fully. I am making every effort to do things in a portable way so I can simply zip the Cmder folder and move my env wherever I want with minimal manual reconfiguration.

The daily use of Cmder has made the changes in this PR seem very obvious to me.

Fixes

  • Fix enhance_path_recursive. It was not adding directories properly.

Adds

  • enhance_path_recursive only enhances the path if a [*.COM|*.EXE|*.BAT|*.CMD|*.PS1|*.VBS] file is in the folder.
  • Add %cmder_root%/opt and Add %cmder_user_config%/opt folders for optional package folders that are not added to the PATH so the user can control exactly what folders get added. This might be necessary if using init.bat /max_depth [1-5].

Changes

@daxgames daxgames added the Work In Progress Work in Progress DO NOT MERGE! label May 10, 2020
@daxgames daxgames removed the Work In Progress Work in Progress DO NOT MERGE! label Jun 7, 2020
Remove cmder_configured goto
Move skip to user config below clink enablement in cmder_configured == 1
If CMDER_CONFIGURED==1 skip to :CMDER_CONFIGURED
@daxgames daxgames merged commit c6edbc0 into cmderdev:master Jun 26, 2020
@daxgames daxgames mentioned this pull request Jun 26, 2020
@daxgames
Copy link
Member Author

@UnderCooled I will look at it.

@daxgames
Copy link
Member Author

daxgames commented Jul 1, 2020

@UnderCooled Try this and let me know if it fixes your issue from above.

@UnderCooled
Copy link

@UnderCooled Try this and let me know if it fixes your issue from above.

Yes, problem fixed. BTW: on line 154 of init.bat(in cmder_mini.zip from artifacts you posted above) there is a single B on that line.

@daxgames
Copy link
Member Author

daxgames commented Jul 2, 2020

@UnderCooled thanks I'll fix that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants