Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify error from _validate_inputs #14

Closed
jennyfothergill opened this issue Oct 1, 2021 · 0 comments · Fixed by #26
Closed

Clarify error from _validate_inputs #14

jennyfothergill opened this issue Oct 1, 2021 · 0 comments · Fixed by #26
Labels
good first issue Good for newcomers

Comments

@jennyfothergill
Copy link
Member

@gwenwhite mentioned some confusion with this error from snap_molecule_cluster and _validate_inputs.

ValueError: Only pass in one of snapshot, gsd_file

Any suggestions for how this error could be better?
Maybe something like "Only pass in a snapshot OR a gsd_file"?
@jennyfothergill jennyfothergill added the good first issue Good for newcomers label Nov 30, 2021
gwenwhite added a commit to gwenwhite/cmeutils that referenced this issue Dec 1, 2021
@gwenwhite
changed value error output in attempt to fix issue cmelab#14.
2701ce4
@gwenwhite gwenwhite mentioned this issue Dec 1, 2021
Closed
gwenwhite added a commit to gwenwhite/cmeutils that referenced this issue Dec 5, 2021
@gwenwhite
changed value error output in attempt to fix issue cmelab#14.
5aa85e9
@chrisjonesBSU chrisjonesBSU linked a pull request Dec 6, 2021 that will close this issue
changed value error output in attempt to fix issue #14. #26
Merged
jennyfothergill added a commit that referenced this issue Dec 6, 2021
@jennyfothergill
Merge pull request #26 from gwenwhite/value-error-2
608d974 
changed value error output in attempt to fix issue #14.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed value error output in attempt to fix issue #14. gwenwhite/cmeutils
1 participant
@jennyfothergill