Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in get_backbone_vector #73

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

chrisjonesBSU
Copy link
Member

I made a last second change that returned the absolute value of the vector, but that broke the expected behavior in flowermd. I don't think it is really necessary to return the absolute value.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cff1f1) 96.01% compared to head (3613e48) 96.01%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files           8        8           
  Lines         677      677           
=======================================
  Hits          650      650           
  Misses         27       27           
Files Coverage Δ
cmeutils/geometry.py 96.92% <100.00%> (ø)

@marjanalbooyeh marjanalbooyeh merged commit 86f8233 into cmelab:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants