STI debug #14

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@sgruhier

Hi

I dont know if it's a good way to fix that, but solialization gem doesn't work well with STI only because rails uses base_classto store the class name in polymorphic column.

https://github.com/rails/rails/blob/master/activerecord/lib/active_record/associations/belongs_to_polymorphic_association.rb#L14

I could add test if you think it worths to merge it

Thanks a lot for your gem!
Seb

Sébastien Gruhier STI compliant 02e8aae
@cmer
Owner
cmer commented Jul 22, 2012

Yeah I think it's a worthwhile addition. Could you just add tests for it please?

Thanks

@sgruhier

sure! I will
On Jul 22, 2012, at 3:18 AM, Carl Mercier wrote:

Yeah I think it's a worthwhile addition. Could you just add tests for it please?

Thanks


Reply to this email directly or view it on GitHub:
#14 (comment)

@cmer
Owner
cmer commented Aug 7, 2013

Closing for now because it's missing tests. I'd love to merge this in however.

@cmer cmer closed this Aug 7, 2013
@cmer cmer reopened this Aug 7, 2013
@cmer cmer closed this Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment