Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect handling of utm_zone #11

Merged
merged 7 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@glostis
Copy link
Collaborator

commented Jun 11, 2019

  • Commit 41a1345 fixes a bug that occurred when a user passed a config.json with a utm_zone value that is different from the default utm_zone for the given ROI (for example by passing 31N when the default zone for the given lon, lat is 30N):
    In that case, the cfg['utm_bbx'] polygon was computed using a utm_zone that was determined by the program (therefore ignoring the user input). This didn't cause s2p to crash, but at the end we had a dsm.tif where the bounds had been computed in zone 30N, but where the CRS of the image was 31N. The dsm.tif was therefore full of nan.

  • Commit 0604464 replaces all occurences of utm in s2p.rpc_utils by pyproj, using some helper functions that were placed in s2p.geographiclib.
    utm is still used in utils/kml_tilemap.py and in s2p.rpc_model. The migration from utm to pyproj in rpc_model.py was already done in the standalone rpcm repository but was not backported to s2p.

glostis and others added some commits Jun 11, 2019

Make output of plyflatten tiled and with nodata
These changes are made to the profile returned by
the function, so that if the raster is written to
disk with `rasterio` it is tiled and with `nodata`
set.
The tests and test data have also been updated
accordingly.
Merge pull request #10 from glostis/rasterization_meta
Make output of plyflatten tiled and with nodata

@carlodef carlodef merged commit 4a3753c into cmla:dev Jun 12, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@glostis glostis deleted the glostis:utm_zone branch Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.