Commit 41a1345 fixes a bug that occurred when a user passed a config.json with a utm_zone value that is different from the default utm_zone for the given ROI (for example by passing 31N when the default zone for the given lon, lat is 30N):
In that case, the cfg['utm_bbx'] polygon was computed using a utm_zone that was determined by the program (therefore ignoring the user input). This didn't cause s2p to crash, but at the end we had a dsm.tif where the bounds had been computed in zone 30N, but where the CRS of the image was 31N. The dsm.tif was therefore full of nan.
Commit 0604464 replaces all occurences of utm in s2p.rpc_utils by pyproj, using some helper functions that were placed in s2p.geographiclib. utm is still used in utils/kml_tilemap.py and in s2p.rpc_model. The migration from utm to pyproj in rpc_model.py was already done in the standalone rpcm repository but was not backported to s2p.
These changes are made to the profile returned by
the function, so that if the raster is written to
disk with `rasterio` it is tiled and with `nodata`
The tests and test data have also been updated
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.