Fix for conversion to UTF8 process failing after the previous update #21

Merged
merged 1 commit into from Dec 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

Isaya commented Dec 1, 2013

Hi cmorgan,

Here is a fix for the UTF8 conversion process. The problem was I switched to STRING_EQUAL_CASE because STING_COMPARE_CASE is marked as legacy, without inverting the expected result as required by WeiDU (I missed the warning in the documentation). This made the Windows test fail but it worked on my computer as git installs a Linux shell that was used when conv_tra.sh was called.

I also included English in the set of languages as there are characters in some dialogs (such as fiancée in lovetalks) that will crash the game.
I checked intallation in French and English and, thanks to an additional trace, I'm sure it uses the proper script now.

Please excuse me for the error in the previous version.

cmorganbg added a commit that referenced this pull request Dec 2, 2013

Merge pull request #21 from Isaya/master
Fix for conversion to UTF8 process failing after the previous update: No worries, Isaya, and thank you so much for your hard work!

@cmorganbg cmorganbg merged commit 2f2190d into cmorganbg:master Dec 2, 2013

Isaya pushed a commit to Isaya/BG1NPC that referenced this pull request Sep 3, 2017

Merge pull request #21 from Isaya/master
Update to French translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment