Browse files

Add tests for @tomika's patch

  • Loading branch information...
1 parent e68c9ea commit f1baae51817288a864b4bca70be8742f841a7ffd @cmr committed Dec 15, 2012
Showing with 24 additions and 1 deletion.
  1. +1 −1 http_parser.c
  2. +23 −0 test.c
View
2 http_parser.c
@@ -866,7 +866,7 @@ size_t http_parser_execute (http_parser *parser,
case s_res_line_almost_done:
STRICT_CHECK(ch != LF);
parser->state = s_header_field_start;
- CALLBACK_NOTIFY(status_complete);
+ CALLBACK_NOTIFY(status_complete);
break;
case s_start_req:
View
23 test.c
@@ -1492,6 +1492,13 @@ request_url_cb (http_parser *p, const char *buf, size_t len)
}
int
+status_complete_cb (http_parser *p) {
+ assert(p == parser);
+ p->data++;
+ return 0;
+}
+
+int
header_field_cb (http_parser *p, const char *buf, size_t len)
{
assert(p == parser);
@@ -3089,6 +3096,20 @@ create_large_chunked_message (int body_size_in_kb, const char* headers)
return buf;
}
+void
+test_status_complete (void)
+{
+ parser_init(HTTP_RESPONSE);
+ parser->data = 0;
+ http_parser_settings settings = settings_null;
+ settings.on_status_complete = status_complete_cb;
+
+ char *response = "don't mind me, just a simple response";
+ http_parser_execute(parser, &settings, response, strlen(response));
+ assert(parser->data == (void*)0); // the status_complete callback was never called
+ assert(parser->http_errno == HPE_INVALID_CONSTANT); // the errno for an invalid status line
+}
+
/* Verify that we can pause parsing at any of the bytes in the
* message and still get the result that we're expecting. */
void
@@ -3396,6 +3417,8 @@ main (void)
, &requests[CONNECT_REQUEST]
);
+ test_status_complete();
+
puts("requests okay");
return 0;

0 comments on commit f1baae5

Please sign in to comment.