Hotfix: Unsafe accesses in BT Navigator #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilyx
requested review from
a team,
jcmonteiro,
LiWeiAn,
SomaGallai and
TanmayDeshmukh
and removed request for
a team
jcmonteiro
approved these changes
Mar 30, 2022
TanmayDeshmukh
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve unsafe access resulting in segfaults in the behaviour tree packages
Approach
Step by step debugging led to two issues: parameters redeclarations and dereferenced pointer access: we now check for both before doing anything.
Open Questions and Pre-Merge TODOs
none
Dependencies
none
Learning
Use GDB with VSCode
Blog Posts
none