Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix support for services connected via IPv6 #1141
@@ Coverage Diff @@ ## master #1141 +/- ## ========================================== + Coverage 61.99% 62.09% +0.09% ========================================== Files 230 230 Lines 16604 16607 +3 ========================================== + Hits 10294 10312 +18 + Misses 6310 6295 -15
Calling getaddrinfo somehow breaks the mocking interface of socket, replacing the MagicMock with the original function. This would break the assert and the test in general. To prevent so getaddrinfo is mocked as well, making it return just an address without side effects.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.