Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for services connected via IPv6 #1141

Open
wants to merge 2 commits into
base: master
from

Conversation

@edomora97
Copy link
Contributor

edomora97 commented Oct 26, 2019

Use the correct address family when connecting to the various RPC services.

The solution is basically the same suggested here:
#157 (comment)


This change is Reviewable

Use the correct address family when connecting to the various RPC services.

The solution is basically the same suggested here:
#157 (comment)

This work is the result of the work of @edomora97, @mark03 and @dariost.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #1141 into master will increase coverage by 0.09%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
+ Coverage   61.99%   62.09%   +0.09%     
==========================================
  Files         230      230              
  Lines       16604    16607       +3     
==========================================
+ Hits        10294    10312      +18     
+ Misses       6310     6295      -15
Flag Coverage Δ
#functionaltests 45.86% <75%> (+0.26%) ⬆️
#unittests 43.29% <50%> (ø) ⬆️
Impacted Files Coverage Δ
cms/io/rpc.py 89.83% <100%> (-1.3%) ⬇️
cms/io/service.py 66.66% <50%> (-2.85%) ⬇️
cms/grading/Job.py 86.72% <0%> (-2.37%) ⬇️
cms/service/ProxyService.py 57.44% <0%> (-1.6%) ⬇️
cms/io/priorityqueue.py 93.43% <0%> (-1.46%) ⬇️
cms/server/admin/handlers/dataset.py 24.76% <0%> (-0.93%) ⬇️
cms/db/usertest.py 95% <0%> (-0.72%) ⬇️
cms/grading/Sandbox.py 67.87% <0%> (ø) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c9e92...07b88e1. Read the comment docs.

Calling getaddrinfo somehow breaks the mocking interface of socket,
replacing the MagicMock with the original function. This would break the
assert and the test in general.
To prevent so getaddrinfo is mocked as well, making it return just an
address without side effects.
@edomora97 edomora97 force-pushed the edomora97:fix/ipv6 branch from 00521b6 to 07b88e1 Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.