diff --git a/DetectorDescription/Core/src/DDFilteredView.cc b/DetectorDescription/Core/src/DDFilteredView.cc index c442540c1ec7a..51cf7ec69edaf 100644 --- a/DetectorDescription/Core/src/DDFilteredView.cc +++ b/DetectorDescription/Core/src/DDFilteredView.cc @@ -243,8 +243,8 @@ void DDFilteredView::print() { << "-------------------" << std::endl << "scope = " << epv_.scope_ << std::endl << "parents:" << std::endl; - for (unsigned int i=0; ifirst)) candidates.push_back(it); } - for (int i=0; ifirst << ' ' << doit << std::endl; std::vector::size_type sz = it->second.size(); // no of 'compatible' namespaces if ( emptyNs && (sz==1) ) { // accept all logical parts in all the namespaces diff --git a/DetectorDescription/Core/src/DDsvalues.cc b/DetectorDescription/Core/src/DDsvalues.cc index f5ca859025f13..9b84942af1c0a 100644 --- a/DetectorDescription/Core/src/DDsvalues.cc +++ b/DetectorDescription/Core/src/DDsvalues.cc @@ -56,8 +56,8 @@ std::ostream & operator<<(std::ostream & os , const DDsvalues_type & s) std::ostream & operator<<(std::ostream & os , const std::vector & v) { - for (unsigned int i=0; i::const_iterator itv = attributes_.begin(); - itv != attributes_.end(); ++itv) + for (const auto & attribute : attributes_) { - for (DDXMLAttribute::const_iterator it = itv->begin(); - it != itv->end(); ++it) + for (DDXMLAttribute::const_iterator it = attribute.begin(); + it != attribute.end(); ++it) os << it->first << " = " << it->second << "\t"; os << std::endl; } diff --git a/DetectorDescription/Parser/src/FIPConfiguration.cc b/DetectorDescription/Parser/src/FIPConfiguration.cc index 617a971791146..b203a27dde2da 100644 --- a/DetectorDescription/Parser/src/FIPConfiguration.cc +++ b/DetectorDescription/Parser/src/FIPConfiguration.cc @@ -49,8 +49,8 @@ FIPConfiguration::dumpFileList(void) const { std::cout << "File List:" << std::endl; std::cout << " number of files=" << files_.size() << std::endl; - for (std::vector::const_iterator it = files_.begin(); it != files_.end(); ++it) - std::cout << *it << std::endl; + for (const auto & file : files_) + std::cout << file << std::endl; } //----------------------------------------------------------------------- diff --git a/DetectorDescription/RegressionTest/test/const_dump.cpp b/DetectorDescription/RegressionTest/test/const_dump.cpp index 1f7296d9af4b2..703f0f789edd7 100644 --- a/DetectorDescription/RegressionTest/test/const_dump.cpp +++ b/DetectorDescription/RegressionTest/test/const_dump.cpp @@ -75,8 +75,8 @@ int main(int argc, char *argv[]) std::cout << vit->toString() << std::endl; const std::vector& tv = *vit; std::cout << "size: " << tv.size() << std::endl; - for (size_t i=0; i < tv.size(); ++i) { - std::cout << tv[i] << "\t"; + for (double i : tv) { + std::cout << i << "\t"; } std::cout << std::endl; } diff --git a/DetectorDescription/RegressionTest/test/tutorial.cc b/DetectorDescription/RegressionTest/test/tutorial.cc index d626693eb8140..a1586c6a83271 100644 --- a/DetectorDescription/RegressionTest/test/tutorial.cc +++ b/DetectorDescription/RegressionTest/test/tutorial.cc @@ -50,7 +50,7 @@ namespace { bool accept(const DDExpandedView &cv ) const final { bool returnValue = true; - for(auto f: filters_) { + for(const auto & f : filters_) { returnValue = returnValue and f->accept(cv); if(not returnValue) { break; @@ -504,10 +504,10 @@ void tutorial() case 's': fv.print(); std::cout << std::endl <<"specifics sets = " << v.size() << ":" << std::endl; - for (spectype::size_type o=0;o::size_type o=0;o