From 39406d34af67883d851916b8751e2165954c4f4d Mon Sep 17 00:00:00 2001
From: Fabio Cossutti <fabio.cossutti@ts.infn.it>
Date: Wed, 4 Jul 2018 10:35:59 +0200
Subject: [PATCH] Revert "Run2-hcx180 Fix a bug for HcalDetId which affects DQM
 of calibration channels"

---
 DataFormats/HcalDetId/src/HcalDetId.cc | 29 ++++----------------------
 1 file changed, 4 insertions(+), 25 deletions(-)

diff --git a/DataFormats/HcalDetId/src/HcalDetId.cc b/DataFormats/HcalDetId/src/HcalDetId.cc
index 553564cca47a8..787b31bae15a0 100644
--- a/DataFormats/HcalDetId/src/HcalDetId.cc
+++ b/DataFormats/HcalDetId/src/HcalDetId.cc
@@ -8,18 +8,7 @@ const HcalDetId HcalDetId::Undefined(HcalEmpty,0,0,0);
 HcalDetId::HcalDetId() : DetId() {
 }
 
-HcalDetId::HcalDetId(uint32_t rawid) {
-  if ((DetId::Detector(rawid>>DetId::kDetOffset)&0xF) != Hcal) {
-    id_ = rawid;
-  } else  {
-    HcalSubdetector subdet = (HcalSubdetector)((rawid>>DetId::kSubdetOffset)&0x7);
-    if ((subdet==HcalBarrel) || (subdet==HcalEndcap) ||
-	(subdet==HcalOuter) || (subdet==HcalForward)) {
-      id_ = newForm(rawid);
-    } else {
-      id_ = rawid;
-    }
-  }
+HcalDetId::HcalDetId(uint32_t rawid) : DetId(newForm(rawid)) {
 }
 
 HcalDetId::HcalDetId(HcalSubdetector subdet, int tower_ieta, int tower_iphi, int depth) : DetId(Hcal,subdet) {
@@ -38,12 +27,7 @@ HcalDetId::HcalDetId(const DetId& gen) {
 	 subdet!=HcalTriggerTower && subdet!=HcalOther)) {
       throw cms::Exception("Invalid DetId") << "Cannot initialize HcalDetId from " << std::hex << gen.rawId() << std::dec; 
     }  
-    if ((subdet==HcalBarrel) || (subdet==HcalEndcap) ||
-	(subdet==HcalOuter) || (subdet==HcalForward)) {
-      id_ = newForm(gen.rawId());
-    } else {
-      id_ = gen.rawId();
-    }
+    id_ = newForm(gen.rawId());
   } else {
     id_ = gen.rawId();
   }
@@ -58,12 +42,7 @@ HcalDetId& HcalDetId::operator=(const DetId& gen) {
 	 subdet!=HcalTriggerTower && subdet!=HcalOther)) {
       throw cms::Exception("Invalid DetId") << "Cannot assign HcalDetId from " << std::hex << gen.rawId() << std::dec; 
     }
-    if ((subdet==HcalBarrel) || (subdet==HcalEndcap) ||
-	(subdet==HcalOuter) || (subdet==HcalForward)) {
-      id_ = newForm(gen.rawId());
-    } else {
-      id_ = gen.rawId();
-    }
+    id_ = newForm(gen.rawId());
   } else {
     id_ = gen.rawId();
   }
@@ -257,7 +236,7 @@ std::ostream& operator<<(std::ostream& s,const HcalDetId& id) {
   case(HcalForward) : return s << "(HF " << id.ieta() << ',' << id.iphi() << ',' << id.depth() << ')';
   case(HcalOuter) : return s << "(HO " << id.ieta() << ',' << id.iphi() << ')';
   case(HcalTriggerTower) : return s << "(HT " << id.ieta() << ',' << id.iphi() << ')';
-  default : return s << std::hex << id.rawId() << std::dec;
+  default : return s << id.rawId();
   }
 }