From e644d739fe3cee0b1c31abfec0b5ee73892ff307 Mon Sep 17 00:00:00 2001 From: camolezi Date: Tue, 16 Jun 2020 19:58:26 +0200 Subject: [PATCH] Delete copy constructor and copy operation, instead of boost inheritance --- CommonTools/Utils/src/MethodInvoker.h | 7 ++++--- DataFormats/Common/interface/MultiAssociation.h | 6 ++++-- FWCore/ParameterSet/interface/ParameterSetConverter.h | 6 ++++-- SimMuon/CSCDigitizer/src/CSCDigitizer.h | 9 +++++---- 4 files changed, 17 insertions(+), 11 deletions(-) diff --git a/CommonTools/Utils/src/MethodInvoker.h b/CommonTools/Utils/src/MethodInvoker.h index 9a75a36ef8977..ff133b17a8ac9 100644 --- a/CommonTools/Utils/src/MethodInvoker.h +++ b/CommonTools/Utils/src/MethodInvoker.h @@ -8,8 +8,6 @@ #include "FWCore/Reflection/interface/ObjectWithDict.h" #include "FWCore/Utilities/interface/TypeID.h" -#include - #include #include @@ -62,7 +60,7 @@ namespace reco { /// - it owns also the object in which to store the result /// - it handles by itself the popping out of Refs and Ptrs /// in this way, it can map 1-1 to a name and set of args - struct SingleInvoker : boost::noncopyable { + struct SingleInvoker { private: // Private Data Members method::TypeCode retType_; std::vector invokers_; @@ -72,6 +70,9 @@ namespace reco { bool isRefGet_; public: + SingleInvoker(const SingleInvoker&) = delete; + SingleInvoker& operator=(const SingleInvoker&) = delete; + SingleInvoker(const edm::TypeWithDict&, const std::string& name, const std::vector& args); ~SingleInvoker(); diff --git a/DataFormats/Common/interface/MultiAssociation.h b/DataFormats/Common/interface/MultiAssociation.h index 77e7d457b6cd6..81fbfbb6f05f4 100644 --- a/DataFormats/Common/interface/MultiAssociation.h +++ b/DataFormats/Common/interface/MultiAssociation.h @@ -51,7 +51,6 @@ #include #include #include -#include #include #include "DataFormats/Common/interface/CMS_CLASS_VERSION.h" #include "DataFormats/Provenance/interface/ProductID.h" @@ -99,8 +98,11 @@ namespace edm { /// It requires to fill items in strict key order. /// You can have a single FastFiller for a given map at time /// You can't access the map for this collection while filling it - class FastFiller : boost::noncopyable { + class FastFiller { public: + FastFiller(const FastFiller &) = delete; + FastFiller &operator=(const FastFiller &) = delete; + /// Make a filler for a collection with a given product id and size FastFiller(IndexRangeAssociation &assoc, ProductID id, unsigned int size); diff --git a/FWCore/ParameterSet/interface/ParameterSetConverter.h b/FWCore/ParameterSet/interface/ParameterSetConverter.h index 1d0bd99186c47..b0871847df708 100644 --- a/FWCore/ParameterSet/interface/ParameterSetConverter.h +++ b/FWCore/ParameterSet/interface/ParameterSetConverter.h @@ -7,7 +7,6 @@ #include #include #include -#include "boost/utility.hpp" #include "DataFormats/Provenance/interface/ParameterSetID.h" #include "DataFormats/Provenance/interface/ParameterSetBlob.h" #include "FWCore/ParameterSet/interface/ParameterSet.h" @@ -38,7 +37,7 @@ namespace edm { // Class ParameterSetConverter typedef std::map ParameterSetMap; - class ParameterSetConverter : private boost::noncopyable { + class ParameterSetConverter { public: typedef std::list StringList; typedef std::map StringMap; @@ -48,6 +47,9 @@ namespace edm { ParameterSetIdConverter& idConverter, bool alreadyByReference); ~ParameterSetConverter(); + ParameterSetConverter(const ParameterSetConverter&) = delete; + ParameterSetConverter& operator=(const ParameterSetConverter&) = delete; + ParameterSetIdConverter const& parameterSetIdConverter() const { return parameterSetIdConverter_; } private: diff --git a/SimMuon/CSCDigitizer/src/CSCDigitizer.h b/SimMuon/CSCDigitizer/src/CSCDigitizer.h index 5feec4ffa3c98..a63b689b7fcfb 100644 --- a/SimMuon/CSCDigitizer/src/CSCDigitizer.h +++ b/SimMuon/CSCDigitizer/src/CSCDigitizer.h @@ -20,7 +20,6 @@ #include "SimDataFormats/CrossingFrame/interface/MixCollection.h" #include "SimDataFormats/TrackingHit/interface/PSimHitContainer.h" #include "SimGeneral/HepPDTRecord/interface/ParticleDataTable.h" -#include #include "DataFormats/Common/interface/DetSetVector.h" #include "SimDataFormats/TrackerDigiSimLink/interface/StripDigiSimLink.h" @@ -38,15 +37,17 @@ namespace CLHEP { class HepRandomEngine; } -class CSCDigitizer : public boost::noncopyable { +class CSCDigitizer { public: typedef edm::DetSetVector DigiSimLinks; + ~CSCDigitizer(); + CSCDigitizer(const CSCDigitizer &) = delete; + CSCDigitizer &operator=(const CSCDigitizer &) = delete; + /// configurable parameters explicit CSCDigitizer(const edm::ParameterSet &p); - ~CSCDigitizer(); - /** digitize */ void doAction(MixCollection &simHits,