From f3bfe9fe5479e2c24f6f372ddadedc45af4ba62f Mon Sep 17 00:00:00 2001
From: Andre Govinda Stahl Leiton <andre.govinda.stahl.leiton@cern.ch>
Date: Tue, 1 May 2018 17:16:55 +0200
Subject: [PATCH] Tune the QT for uGMT and add uGMT-EMTF HW sign QT

---
 .../data/L1TStage2uGMTQualityTests.xml        | 58 ++++++++++++++-----
 .../python/L1TStage2EventInfoClient_cfi.py    |  5 ++
 2 files changed, 48 insertions(+), 15 deletions(-)

diff --git a/DQM/L1TMonitorClient/data/L1TStage2uGMTQualityTests.xml b/DQM/L1TMonitorClient/data/L1TStage2uGMTQualityTests.xml
index 0451b7bd86f9a..a930070407589 100644
--- a/DQM/L1TMonitorClient/data/L1TStage2uGMTQualityTests.xml
+++ b/DQM/L1TMonitorClient/data/L1TStage2uGMTQualityTests.xml
@@ -64,8 +64,6 @@
       <TestName activate="true">uGMT_MuonPtRange</TestName>
   </LINK>
 
-  <!-- uGMT Muon Phi-Eta -->
-
 
   <!-- uGMT BMTF Quality Tests -->
 
@@ -118,8 +116,8 @@
   <QTEST name="uGMT_BMTFhwEtaSpectrum">
     <TYPE>Comp2RefKolmogorov</TYPE>	
     <PARAM name="testparam">0</PARAM>
-    <PARAM name="error">0.01</PARAM>
-    <PARAM name="warning">0.10</PARAM>
+    <PARAM name="error">0.00000001</PARAM>
+    <PARAM name="warning">0.01</PARAM>
   </QTEST>
 
   <QTEST name="uGMT_BMTFhwEtaMeanAt0">
@@ -144,11 +142,16 @@
   <!-- uGMT BMTF HW Sign -->
 
   <QTEST name="uGMT_BMTFhwSignUniform">
-    <TYPE>NoisyChannel</TYPE>	
-    <PARAM name="tolerance">0.3</PARAM>
-    <PARAM name="neighbours">2</PARAM>
-    <PARAM name="error">0.996</PARAM>
-    <PARAM name="warning">0.999</PARAM>
+    <TYPE>MeanWithinExpected</TYPE>
+    <PARAM name="mean">0.5</PARAM>
+    <PARAM name="useRMS">0</PARAM>
+    <PARAM name="useSigma">0</PARAM>
+    <PARAM name="useRange">1</PARAM>
+    <PARAM name="xmin">0.45</PARAM>
+    <PARAM name="xmax">0.55</PARAM>
+    <PARAM name="error">0.95</PARAM>
+    <PARAM name="warning">0.99</PARAM>
+    <PARAM name="minEntries">100</PARAM>
   </QTEST>
 
   
@@ -221,8 +224,8 @@
   <QTEST name="uGMT_OMTFhwEtaSpectrum">
     <TYPE>Comp2RefKolmogorov</TYPE>	
     <PARAM name="testparam">0</PARAM>
-    <PARAM name="error">0.01</PARAM>
-    <PARAM name="warning">0.04</PARAM>
+    <PARAM name="error">0.00000001</PARAM>
+    <PARAM name="warning">0.01</PARAM>
   </QTEST>
 
   <QTEST name="uGMT_OMTFhwEtaMeanAt0">
@@ -261,11 +264,16 @@
   <!-- uGMT OMTF HW Sign -->
 
   <QTEST name="uGMT_OMTFhwSignUniform">
-    <TYPE>NoisyChannel</TYPE>	
-    <PARAM name="tolerance">0.3</PARAM>
-    <PARAM name="neighbours">2</PARAM>
-    <PARAM name="error">0.96</PARAM>
+    <TYPE>MeanWithinExpected</TYPE>
+    <PARAM name="mean">0.5</PARAM>
+    <PARAM name="useRMS">0</PARAM>
+    <PARAM name="useSigma">0</PARAM>
+    <PARAM name="useRange">1</PARAM>
+    <PARAM name="xmin">0.45</PARAM>
+    <PARAM name="xmax">0.55</PARAM>
+    <PARAM name="error">0.95</PARAM>
     <PARAM name="warning">0.99</PARAM>
+    <PARAM name="minEntries">100</PARAM>
   </QTEST>
 
   
@@ -333,6 +341,26 @@
       <TestName activate="true">uGMT_EMTFMuonPhiMeanAt0</TestName>
   </LINK>
 
+  <!-- uGMT EMTF HW Sign -->
+
+  <QTEST name="uGMT_EMTFhwSignUniform">
+    <TYPE>MeanWithinExpected</TYPE>
+    <PARAM name="mean">0.5</PARAM>
+    <PARAM name="useRMS">0</PARAM>
+    <PARAM name="useSigma">0</PARAM>
+    <PARAM name="useRange">1</PARAM>
+    <PARAM name="xmin">0.45</PARAM>
+    <PARAM name="xmax">0.55</PARAM>
+    <PARAM name="error">0.95</PARAM>
+    <PARAM name="warning">0.99</PARAM>
+    <PARAM name="minEntries">100</PARAM>
+  </QTEST>
+
+
+  <LINK name="*/L1TStage2uGMT/*/ugmtEMTFhwSign">
+      <TestName activate="true">uGMT_EMTFhwSignUniform</TestName>
+  </LINK>
+
   <!-- uGMT Mismatch Summary QTest -->
 
   <!-- BMTF Output vs uGMT Input -->
diff --git a/DQM/L1TMonitorClient/python/L1TStage2EventInfoClient_cfi.py b/DQM/L1TMonitorClient/python/L1TStage2EventInfoClient_cfi.py
index 130939e3a6175..2ca1ce0462511 100644
--- a/DQM/L1TMonitorClient/python/L1TStage2EventInfoClient_cfi.py
+++ b/DQM/L1TMonitorClient/python/L1TStage2EventInfoClient_cfi.py
@@ -265,6 +265,11 @@
                                 QualityTestHist = cms.string("L1T/L1TStage2uGMT/ugmtMuonPhiEmtf"),
                                 QualityTestSummaryEnabled = cms.uint32(1)
                                 ),
+                            cms.PSet(
+                                QualityTestName = cms.string("uGMT_EMTFhwSignUniform"),
+                                QualityTestHist = cms.string("L1T/L1TStage2uGMT/EMTFInput/ugmtEMTFhwSign"),
+                                QualityTestSummaryEnabled = cms.uint32(1)
+                                ),
                             cms.PSet(
                                 QualityTestName = cms.string("BMTFvsuGMT_MismatchRatioMax0"),
                                 QualityTestHist = cms.string("L1T/L1TStage2uGMT/BMTFoutput_vs_uGMTinput/mismatchRatio"),