-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda:Run2-hcx89 Add DB objects for HCAL TP #15521
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_1_X. It involves the following packages: CalibCalorimetry/HcalAlgos @ghellwig, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 Tested at: ce1cb26 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/JsonWritingTimeoutPoolOutputModule.cc Copying tmp/slc6_amd64_gcc530/src/RecoMET/METProducers/test/testRecoMETMETProducers/testRecoMETMETProducers to productstore area: >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/TriggerSelector.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/DQMServices/StreamerIO/plugins/DQMMonitoringService.cc /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc: In member function 'void HcalDbProducer::TPChannelParametersCallback(const HcalTPChannelParametersRcd&)': /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:424:48: error: no matching function for call to 'HcalDbService::setData(std::unique_ptr::pointer)' mService->setData (mTPChannelParameters.get()); ^ In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.h:31:0, from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:33: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibFormats/HcalObjects/interface/HcalDbService.h:57:8: note: candidate: void HcalDbService::setData(const HcalPedestals*)
I found a compilation error while trying to compile with clang: ^ 1 warning generated. >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalZDCLowGainFractionsHandler.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalLongRecoParamsHandler.cc >> Compiling /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CondTools/Hcal/src/HcalChannelQualityHandler.cc /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-1400/src/CalibCalorimetry/HcalPlugins/src/HcalDbProducer.cc:424:13: error: no matching member function for call to 'setData' mService->setData (mTPChannelParameters.get()); ~~~~~~~~~~^~~~~~~ /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-08-18-1400/src/CalibFormats/HcalObjects/interface/HcalDbService.h:57:8: note: candidate function not viable: no known conversion from 'pointer' (aka 'HcalTPChannelParameters _') to 'const HcalPedestals *' for 1st argument void setData (const HcalPedestals_ fItem) {mPedestals = fItem; mCalibSet = nullptr;} ^ |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 Tested at: 126794c You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/ComponentFactory.h:28, from /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/ModuleFactory.h:26, from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-2300/src/CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc:26: /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/DependentRecordImplementation.h: In instantiation of 'const DepRecordT& edm::eventsetup::DependentRecordImplementation::getRecord() const [with DepRecordT = HcalRecNumberingRecord; RecordT = HcalDbRecord; ListT = boost::mpl::vector]': /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_8_1_X_2016-08-18-2300/src/CalibCalorimetry/HcalTPGEventSetup/src/HcalTPGCoderULUT.cc:143:44: required from here /cvmfs/cms-ib.cern.ch/2016-34/slc6_amd64_gcc530/external/boost/1.57.0-giojec/include/boost/static_assert.hpp:78:41: error: static assertion failed: (! boost::is_same::value) # define BOOST_STATIC_ASSERT( ... ) static_assert(**VA_ARGS**, #**VA_ARGS**) ^ /cvmfs/cms-ib.cern.ch/week0/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_8_1_X_2016-08-18-2300/src/FWCore/Framework/interface/DependentRecordImplementation.h:51:9: note: in expansion of macro 'BOOST_STATIC_ASSERT' BOOST_STATIC_ASSERT((! boost::is_same::value)); ^ |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
This adds 2 data base objects: HcalTPParameters which summarizes the TP implementation and HcalTPChannelParameters which contains parameters for each channel