Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MET EE noise mitigation in 2017 data #24876

Merged
merged 25 commits into from Oct 24, 2018

Conversation

eioannou
Copy link
Contributor

@eioannou eioannou commented Oct 15, 2018

This Pull Request includes the recipe which was created for the EE noise mitigation in 2017 data. It removes bad pf candidates clustered to jets by adding new modules for fix EE in MET tool. It adds the fixEE2017 and fixEE2017Params parameters to MET tool.

This recipe creates a new pfcandidates collection which does not include the lower pt jets in the high-eta endcap region which are mostly affected by EE noise. It removes all jets and associated PF candidates with pt<50 GeV and 2.65 <|eta| < 3.139 before calculating MET.

More details of the recipe can be found here: https://indico.cern.ch/event/759372/contributions/3149378/attachments/1721436/2802416/metreport.pdf

cc: @peruzzim

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #24876 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31170/console Started: 2018/10/19 16:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24876/31170/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@perrotta
Copy link
Contributor

+1

  • By using the default parameters in PhysicsTools/PatUtils/python/tools/runMETCorrectionsAndUncertainties.py the newly added filter is disabled, and therefore no effect can be propagated to the standard workflows (and no effect is seen in the results of the jenkins tests, in fact): as such the pull request can be merged without modifying the default behaviour, and it is therefore suitable for being backported.
  • By setting by hand the flag to true I could verify the effect in the miniAOD output on a TTbar sample (it was wf 11624, TTbar MC in 2019 configuration: the one that I had at hand). For example:
    all_mini_testpr24876vsorig_ttbar13tev2019wf11624p0c_patmets_slimmedmetspuppi__reco_obj_pt.
    • The flag can be switched on in analyses or in some possible dedicated re-miniAOD campaign

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants