Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Add ParticleNet to NanoAOD #31244

Merged
merged 4 commits into from
Aug 29, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Aug 25, 2020

PR description:

Backport of #31096.

This PR adds the ParticleNet tagger to NanoAOD. The following scores will be included in NanoAOD:

  • ParticleNet: TvsQCD, WvsQCD, ZvsQCD, HbbvsQCD, HccvsQCD, H4qvsQCD, QCD
  • ParticleNet-MD: Xbb, Xcc, Xqq, QCD

The ParticleNet tagger needs to run in the NanoAOD sequence until we have the tagger stored in MiniAOD. The updated training [V01] should be used for both UL and EOY samples.

FYI @camclean @alefisico

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2020

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD
RecoBTag/ONNXRuntime

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@emilbols, @smoortga, @JyothsnaKomaragiri, @ferencek, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

@hqucms
The use of modifiers is not appropriate we have to use the run2_miniAOD_devel (like for all the other back ports)

if run2_miniAOD_devel:
all will be available in miniAOD

if (~run2_miniAOD_devel) recompute stuff

@hqucms
Copy link
Contributor Author

hqucms commented Aug 25, 2020

@hqucms
The use of modifiers is not appropriate we have to use the run2_miniAOD_devel (like for all the other back ports)

if run2_miniAOD_devel:
all will be available in miniAOD

if (~run2_miniAOD_devel) recompute stuff

@mariadalfonso
Is this for the no-change policy (i.e., the new taggers should only be added when run2_miniAOD_devel is enabled)?

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Aug 26, 2020

@hqucms
The use of modifiers is not appropriate we have to use the run2_miniAOD_devel (like for all the other back ports)
if run2_miniAOD_devel:
all will be available in miniAOD
if (~run2_miniAOD_devel) recompute stuff

@mariadalfonso
Is this for the no-change policy (i.e., the new taggers should only be added when run2_miniAOD_devel is enabled)?

You are adding new variables for particleNet, and in previous eras the analyser will not use them so there is no problem if some variable is present in some dataset. For the old tagger you were already re-running them before, so this will result in no change.

The new mini in 10_6 are controlled by the run2_miniAOD_devel, so you can take particleNet from mini and add in nano only when the run2_miniAOD_devel is enabled.

@slava77
Copy link
Contributor

slava77 commented Aug 26, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: cb85649
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc915/8941/summary.html
CMSSW: CMSSW_10_6_X_2020-08-25-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc915/8941/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214614
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214279
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.114 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 2.114 KiB Physics/NanoAODDQM
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

backport of #31096

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 9cf15b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc915/8969/summary.html
CMSSW: CMSSW_10_6_X_2020-08-27-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fc915/8969/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 3214618
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3214283
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.114 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 2.114 KiB Physics/NanoAODDQM
  • Checked 140 log files, 14 edm output root files, 34 DQM output files

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Aug 28, 2020

+xpog
Taggers added in nano directly from mini when minAOD_devel is active otherwise recomputed, new branch "ParticleNet" not present in previous nano will be available.

@slava77
Copy link
Contributor

slava77 commented Aug 28, 2020

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 29, 2020

+1

@cmsbuild cmsbuild merged commit ff58396 into cms-sw:CMSSW_10_6_X Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants