-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_6_X] Add ParticleNet to NanoAOD #31244
Conversation
A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X. It involves the following packages: PhysicsTools/NanoAOD @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@hqucms if run2_miniAOD_devel: if (~run2_miniAOD_devel) recompute stuff |
@mariadalfonso |
You are adding new variables for particleNet, and in previous eras the analyser will not use them so there is no problem if some variable is present in some dataset. For the old tagger you were already re-running them before, so this will result in no change. The new mini in 10_6 are controlled by the run2_miniAOD_devel, so you can take particleNet from mini and add in nano only when the run2_miniAOD_devel is enabled. |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
backport of #31096 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+xpog |
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport of #31096.