Global CaloL1 DQM Fix

[aloeliger]

PR description:

This PR adds fixes on top of the reverted CaloL1 DQM "Global" module change #32004, fixing issue #32172. The segmentation violation was caused by a bad binary search in a list of recent mismatches (caused by 2 issues: a wrongly shifted search location, and failure to exclude the previous search location from new search bounds) which caused a stack overflow.

PR validation:

The code compiles, and has been tested for online and single threaded offline use was tested in previous PR #32004. In addition, this change has now been tested on offline workflows 136.721 and 136.731 using 4 threads successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32205/19948

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/L1TMonitor/interface/L1TStage2CaloLayer1.h modified in PR(s): [TEST-ONLY] Restore "Revert "Move CaloL1 online DQM to Global"" #32182
  • File DQM/L1TMonitor/src/L1TStage2CaloLayer1.cc modified in PR(s): [TEST-ONLY] Restore "Revert "Move CaloL1 online DQM to Global"" #32182

[cmsbuild]

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

DQM/L1TMonitor
DQMServices/Core
DQMServices/Demo

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-19-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10889/console Started: 2020/11/20 14:33

[cmsbuild]

+1
Tested at: b1abc53
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a635/10889/summary.html
CMSSW: CMSSW_11_2_X_2020-11-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a635/10889/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d1a635/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d1a635/11642.911_ZMM_13+2021_DD4hep+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2962300
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2962267
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[jfernan2]

@aloeliger the L1TStage2CaloLayer1 class is producing a crash at Online in view of the next MWGR:

Fatal Exception (Exit Code: 8022)An exception of category 'FatalRootError' occurred while
[0] Calling InputSource::readRun_
Additional Info:
[a] Fatal Root Error: @sub=TH1Merger::CheckForDuplicateLabels
Histogram last20Mismatches has duplicate labels in the y axis. Bin contents will be merged in a single bin

The issue seems to be located on:
https://github.com/aloeliger/cmssw/blob/b1abc53b4cda374f5f261df16232e2a74f3424b7/DQM/L1TMonitor/src/L1TStage2CaloLayer1.cc#L743-L752