From 36c4ff6a608cfe0f25f5ad9864d953eea7dddcfc Mon Sep 17 00:00:00 2001
From: Riccardo Manzoni <riccardo.manzoni@cern.ch>
Date: Fri, 11 Dec 2020 16:18:29 +0100
Subject: [PATCH 1/2] fix logic: break loop once the filter condition is
 satisfied, no need to loop further

---
 GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc b/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
index f09745c6dfa4c..6e7470c73ce04 100644
--- a/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
+++ b/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
@@ -150,6 +150,8 @@ bool PythiaFilterMultiAncestor::filter(edm::Event& iEvent, const edm::EventSetup
       }
          */
       }
+      // only need to satisfy the conditions _once_
+      if(accepted) break;
     }
 
   } else {

From 67f92a3bfd0678892616ca138fb47f3f118e73e5 Mon Sep 17 00:00:00 2001
From: Riccardo Manzoni <riccardo.manzoni@cern.ch>
Date: Fri, 11 Dec 2020 16:19:42 +0100
Subject: [PATCH 2/2] code style

---
 GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc b/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
index 6e7470c73ce04..5bd8caf4b82d2 100644
--- a/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
+++ b/GeneratorInterface/GenFilters/src/PythiaFilterMultiAncestor.cc
@@ -151,7 +151,8 @@ bool PythiaFilterMultiAncestor::filter(edm::Event& iEvent, const edm::EventSetup
          */
       }
       // only need to satisfy the conditions _once_
-      if(accepted) break;
+      if (accepted)
+        break;
     }
 
   } else {