New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinymce4: CDN or full version? #206

Closed
manu37 opened this Issue Apr 18, 2017 · 12 comments

Comments

Projects
None yet
4 participants
@manu37
Contributor

manu37 commented Apr 18, 2017

Generally two versions are provided: one with full tinymce JS library, one CDN Version without local JS library (but with langs). My proposition is to deliver the CDN Version by default. And put into the Dist documentation a hint where to download the full fledged version.
Any opinions?

@frase-git

This comment has been minimized.

Show comment
Hide comment
@frase-git

frase-git Apr 18, 2017

Ich bevorzuge die full-Version (local).
Zum einen, weil ich oft offline entwickle.
Zum anderen, weil die CDN auch schon mal unregelmäßig erreichbar sein kann (auch schon war).
Sorry.

Ich bevorzuge die full-Version (local).
Zum einen, weil ich oft offline entwickle.
Zum anderen, weil die CDN auch schon mal unregelmäßig erreichbar sein kann (auch schon war).
Sorry.

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Apr 18, 2017

Member

Zum einen, weil ich oft offline entwickle.

That's a good argument; on the other hand, the CDN only version is supposed to be much smaller (BTW: the downloads on https://sourceforge.net/projects/tinymce4cmsimplexh/files/?source=navbar have equal size).

Zum anderen, weil die CDN auch schon mal unregelmäßig erreichbar sein kann (auch schon war).

That would be bad.

Anyhow, is it a good idea to use cdn.tinymce.com/4/tinymce.min.js as default? Is relying on the major version number only stable enough, i.e. are they strictly following semver?

Member

cmb69 commented Apr 18, 2017

Zum einen, weil ich oft offline entwickle.

That's a good argument; on the other hand, the CDN only version is supposed to be much smaller (BTW: the downloads on https://sourceforge.net/projects/tinymce4cmsimplexh/files/?source=navbar have equal size).

Zum anderen, weil die CDN auch schon mal unregelmäßig erreichbar sein kann (auch schon war).

That would be bad.

Anyhow, is it a good idea to use cdn.tinymce.com/4/tinymce.min.js as default? Is relying on the major version number only stable enough, i.e. are they strictly following semver?

@manu37

This comment has been minimized.

Show comment
Hide comment
@manu37

manu37 Apr 18, 2017

Contributor

(BTW: the downloads on https://sourceforge.net/projects/tinymce4cmsimplexh/files/?source=navbar have equal size).

This is a mistake. The CDN Variant should be 1,1MB & 108 files lighter.

Anyhow, is it a good idea to use cdn.tinymce.com/4/tinymce.min.js as default?

Everytime I visit the tinymce site, there is another way to link the CDN Version..
The new Cloud version needs a API key though..

Contributor

manu37 commented Apr 18, 2017

(BTW: the downloads on https://sourceforge.net/projects/tinymce4cmsimplexh/files/?source=navbar have equal size).

This is a mistake. The CDN Variant should be 1,1MB & 108 files lighter.

Anyhow, is it a good idea to use cdn.tinymce.com/4/tinymce.min.js as default?

Everytime I visit the tinymce site, there is another way to link the CDN Version..
The new Cloud version needs a API key though..

@manu37

This comment has been minimized.

Show comment
Hide comment
@manu37

manu37 Apr 18, 2017

Contributor

As I read the notice about tinyMCE Cloud deployment, we better stick to the local variant. As a next step I might make the Cloud Access configurable. Register for an API key is then a matter of the user.

Contributor

manu37 commented Apr 18, 2017

As I read the notice about tinyMCE Cloud deployment, we better stick to the local variant. As a next step I might make the Cloud Access configurable. Register for an API key is then a matter of the user.

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Apr 18, 2017

Member

This is a mistake. The CDN Variant should be 1,1MB & 108 files lighter.

Ah, thanks. This makes, of course, quite a difference.

As I read the notice about tinyMCE Cloud deployment, we better stick to the local variant.

We might also use https://cdnjs.com/libraries/tinymce, instead.

Member

cmb69 commented Apr 18, 2017

This is a mistake. The CDN Variant should be 1,1MB & 108 files lighter.

Ah, thanks. This makes, of course, quite a difference.

As I read the notice about tinyMCE Cloud deployment, we better stick to the local variant.

We might also use https://cdnjs.com/libraries/tinymce, instead.

@lck-git

This comment has been minimized.

Show comment
Hide comment
@lck-git

lck-git Apr 18, 2017

[frase-git]Ich bevorzuge die full-Version (local).
Zum einen, weil ich oft offline entwickle.

Ich auch!
Problem: bei voreingestellter CDN-Version und ohne Internetverbindung, der Editor erscheint nicht und es gibt auch keinen Hinweis darauf, dass eine aktive Interverbindung notwendig ist :(

lck-git commented Apr 18, 2017

[frase-git]Ich bevorzuge die full-Version (local).
Zum einen, weil ich oft offline entwickle.

Ich auch!
Problem: bei voreingestellter CDN-Version und ohne Internetverbindung, der Editor erscheint nicht und es gibt auch keinen Hinweis darauf, dass eine aktive Interverbindung notwendig ist :(

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Apr 18, 2017

Member

Problem: bei voreingestellter CDN-Version und ohne Internetverbindung, der Editor erscheint nicht und es gibt auch keinen Hinweis darauf, dass eine aktive Interverbindung notwendig ist :(

Das ist nicht schön, könnte aber relativ leicht gelöst werden, in etwa:

if (!tinymce) {
    alert("TinyMCE couldn't be loaded. Are you offline?");
}
Member

cmb69 commented Apr 18, 2017

Problem: bei voreingestellter CDN-Version und ohne Internetverbindung, der Editor erscheint nicht und es gibt auch keinen Hinweis darauf, dass eine aktive Interverbindung notwendig ist :(

Das ist nicht schön, könnte aber relativ leicht gelöst werden, in etwa:

if (!tinymce) {
    alert("TinyMCE couldn't be loaded. Are you offline?");
}
@manu37

This comment has been minimized.

Show comment
Hide comment
@manu37

manu37 Apr 18, 2017

Contributor

We might also use https://cdnjs.com/libraries/tinymce, instead.

Nice. This is already configurable in the plugins "alternate CDN Source".
I think I stay with the two plugin versions and we all decide which variant will be implemented by default.

Contributor

manu37 commented Apr 18, 2017

We might also use https://cdnjs.com/libraries/tinymce, instead.

Nice. This is already configurable in the plugins "alternate CDN Source".
I think I stay with the two plugin versions and we all decide which variant will be implemented by default.

@cmb69 cmb69 added this to the 1.7 milestone May 7, 2017

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 May 7, 2017

Member

I think I stay with the two plugin versions and we all decide which variant will be implemented by default.

I don't mind which variant will be the default – there are good arguments pro and con.

Member

cmb69 commented May 7, 2017

I think I stay with the two plugin versions and we all decide which variant will be implemented by default.

I don't mind which variant will be the default – there are good arguments pro and con.

@cmb69 cmb69 added the voting label May 7, 2017

@manu37

This comment has been minimized.

Show comment
Hide comment
@manu37

manu37 May 9, 2017

Contributor

Honestly, in regard of the package size (saves 0,5MB) and the fact that the majority works online I would suggest to roll out the CDN Version. The host https://cdnjs.com/libraries/tinymce is quite up to date. Its easy to illustrate how to install tinyMCE manually and switch to the local variant.

Contributor

manu37 commented May 9, 2017

Honestly, in regard of the package size (saves 0,5MB) and the fact that the majority works online I would suggest to roll out the CDN Version. The host https://cdnjs.com/libraries/tinymce is quite up to date. Its easy to illustrate how to install tinyMCE manually and switch to the local variant.

@cmb69 cmb69 added to be implemented and removed voting labels May 26, 2017

@manu37

This comment has been minimized.

Show comment
Hide comment
@manu37

manu37 Jun 28, 2017

Contributor

I'm working on it. The update is the least, a proper documentation is the effort..

Contributor

manu37 commented Jun 28, 2017

I'm working on it. The update is the least, a proper documentation is the effort..

@manu37 manu37 referenced this issue Jun 29, 2017

Merged

Cdn enhancements #264

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Jul 2, 2017

Member

Since PR #264 has been closed, this ticket can be closed as well.

Member

cmb69 commented Jul 2, 2017

Since PR #264 has been closed, this ticket can be closed as well.

@cmb69 cmb69 closed this Jul 2, 2017

@cmb69 cmb69 removed the to be implemented label Jul 2, 2017

@cmb69 cmb69 modified the milestones: 1.7.0, 1.7 Jul 2, 2017

@manu37 manu37 referenced this issue Jul 22, 2017

Closed

Load-Fehler #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment