New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log PHP errors when debug mode is enabled #279

Open
cmb69 opened this Issue Aug 12, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@cmb69
Member

cmb69 commented Aug 12, 2017

If debug mode is enabled, PHP errors (i.e. notices, warnings, etc.) are supposed to be displayed between the admin menu and the actual page. However, there are many cases where these error messages never will be seen for reasons including the following:

  • the error occurs during an Ajax request which does not refresh the full page (rather common for Ajax requests)
  • the system redirects to another page
  • the request is not triggered by the admin, but rather someone else

Therefore, I suggest to log all errors which are supposed to be handled for a particular debug mode additionally to a file. This could be the configured error_log (by calling error_log()), or maybe preferably the general log file of CMSimple_XH, because this is always available and can easily be inspected online.

@cmb69 cmb69 added this to the 1.7.1 milestone Aug 12, 2017

@cmb69 cmb69 modified the milestones: 1.7.1, 1.8 Oct 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment