New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some languages wont show seperate login form #295

Closed
manu37 opened this Issue Sep 8, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@manu37
Contributor

manu37 commented Sep 8, 2017

In loginforms() the global $f is overwritten by the localized $tx['menu']['login']. Don't know why. In the Dutch case, this is "Inloggen". Therefore in cms.php 1325 the wrong themplate is chosen.

@manu37 manu37 added the bug label Sep 8, 2017

@cmb69 cmb69 added this to the 1.7.1 milestone Sep 8, 2017

@cmb69

This comment has been minimized.

Member

cmb69 commented Sep 8, 2017

In loginforms() the global $f is overwritten by the localized $tx['menu']['login']. Don't know why.

Because CMSimple sets the page title to $f if not already set, confusing model values ($f) and view values ($title).

Apparently, the only other case where this happens in the standard distro is wrt. the site-info which has to be fixed as well.

To avoid future issues in this regard, we should consider to remove the fallback on using $f as $title altogether.

@manu37

This comment has been minimized.

Contributor

manu37 commented Sep 8, 2017

But then at least set $f to a static 'login'. And try to set the $title with a localized $tx[menu][$f] if present.

@cmb69

This comment has been minimized.

Member

cmb69 commented Sep 13, 2017

But then at least set $f to a static 'login'. And try to set the $title with a localized $tx[menu][$f] if present.

Yes, that's what I meant.

@cmb69 cmb69 changed the title from Demo Website: Dutch page wont show seperate login form to Some languages wont show seperate login form Sep 29, 2017

@cmb69 cmb69 closed this in 91e5de0 Oct 1, 2017

cmb69 added a commit that referenced this issue Oct 1, 2017

Merge branch '1.7'
* 1.7:
  Fix #295: Some languages wont show seperate login form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment