New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Form detached from Template #36

Closed
cmb69 opened this Issue Feb 23, 2017 · 4 comments

Comments

Projects
None yet
1 participant
@cmb69
Member

cmb69 commented Feb 23, 2017

@cmb69 cmb69 added this to the 1.7.0 milestone Feb 23, 2017

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Feb 24, 2017

Member

This would be solved by uncommenting these two lines, so a PR appears to be overkill.

Member

cmb69 commented Feb 24, 2017

This would be solved by uncommenting these two lines, so a PR appears to be overkill.

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Feb 24, 2017

Member

This would be solved by uncommenting these two lines, so a PR appears to be overkill.

Actually, XH_builtinTemplate() is already too specific; for instance, it includes the core, template and plugins stylesheet. It seems to be preferable to use an even more minimalistic template for the login and the password forgotten pages. Therefore, I'd prefer a PR yet again.

Member

cmb69 commented Feb 24, 2017

This would be solved by uncommenting these two lines, so a PR appears to be overkill.

Actually, XH_builtinTemplate() is already too specific; for instance, it includes the core, template and plugins stylesheet. It seems to be preferable to use an even more minimalistic template for the login and the password forgotten pages. Therefore, I'd prefer a PR yet again.

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Feb 24, 2017

Member

Actually, XH_builtinTemplate() is already too specific; […]

After reconsideration I think XH_builtinTemplate() is pretty reasonable for the normal use, and still okay for a maintainence mode; after all, if the stylesheets are broken, this would be even more problematic for the admin mode.

Member

cmb69 commented Feb 24, 2017

Actually, XH_builtinTemplate() is already too specific; […]

After reconsideration I think XH_builtinTemplate() is pretty reasonable for the normal use, and still okay for a maintainence mode; after all, if the stylesheets are broken, this would be even more problematic for the admin mode.

@cmb69 cmb69 added the voting label Feb 25, 2017

@cmb69

This comment has been minimized.

Show comment
Hide comment
@cmb69

cmb69 Feb 25, 2017

Member

I suggest to merge PR #155.

Member

cmb69 commented Feb 25, 2017

I suggest to merge PR #155.

@cmb69 cmb69 added to be implemented and removed voting labels Mar 16, 2017

@cmb69 cmb69 closed this in bd0a68e Mar 16, 2017

@cmb69 cmb69 added enhancement and removed to be implemented labels Mar 16, 2017

@cmb69 cmb69 modified the milestones: 1.7.0beta1, 1.7 Mar 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment