Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various guns have no lineart sprite when viewing weapon stats #5733

Closed
3 of 42 tasks
Drulikar opened this issue Feb 16, 2024 · 0 comments · Fixed by #6905
Closed
3 of 42 tasks

Various guns have no lineart sprite when viewing weapon stats #5733

Drulikar opened this issue Feb 16, 2024 · 0 comments · Fixed by #6905
Labels
Confirmed Bug We have the same at home! Consistency Issue Who needs consistency? Sprites Remove the soul from the game.

Comments

@Drulikar
Copy link
Contributor

Testmerges

N/A

Round ID

N/A

Description of the bug

See #5729 These guns will currently spit out a debug message because they do not have a corresponding lineart sprite (so will display the no_name sprite instead) when viewing the weapon stats via examine:

  • /obj/item/weapon/gun/pistol/np92, icon_state="np92" & /obj/item/weapon/gun/pistol/np92/suppressed+/tranq, icon_state="npz92"
  • /obj/item/weapon/gun/pistol/t73, icon_state="tt" & /obj/item/weapon/gun/pistol/t73/leader, icon_state="ttb"
  • /obj/item/weapon/gun/pistol/clfpistol, icon_state="m43"
  • /obj/item/weapon/gun/pistol/es4, icon_state="es4"
  • /obj/item/weapon/gun/energy/rxfm5_eva, icon_state="rxfm5_eva"
  • /obj/item/weapon/gun/launcher/rocket/anti_tank+/disposable, icon_state="m83a2"
  • /obj/item/weapon/gun/launcher/rocket/upp, icon_state="hjra12"
  • /obj/item/weapon/gun/rifle/m41a/elite/xm40+/ap, icon_state="m40sd"
  • /obj/item/weapon/gun/rifle/nsg23+/stripped+/no_lock+no_lock/stripped, icon_state="nsg23"
  • /obj/item/weapon/gun/rifle/mar40/lmg+/tactical, icon_state="mar50"
  • /obj/item/weapon/gun/rifle/xm177+/dutch, icon_state="xm177"
  • /obj/item/weapon/gun/rifle/ar10, icon_state="ar10"
  • /obj/item/weapon/gun/rifle/m4ra+/training, icon_state="m4ra"
  • /obj/item/weapon/gun/rifle/m4ra_custom, icon_state="m4ra_custom"
  • /obj/item/weapon/gun/rifle/l42a/abr40, icon_state="abr40" & /obj/item/weapon/gun/rifle/l42a/abr40, icon_state="abr40_tac"
  • /obj/item/weapon/gun/rifle/rmc_f90, icon_state="aug" & /obj/item/weapon/gun/rifle/rmc_f90/a_grip, icon_state="aug_com" & /obj/item/weapon/gun/rifle/rmc_f90/scope, icon_state="aug_dmr" & /obj/item/weapon/gun/rifle/rmc_f90/shotgun, icon_state="aug_mkey"
  • /obj/item/weapon/gun/rifle/sniper/XM43E1, icon_state="xm43e1"
  • /obj/item/weapon/gun/rifle/sniper/svd, icon_state="type88"
  • /obj/item/weapon/gun/boltaction, icon_state="boltaction"
  • /obj/item/weapon/gun/boltaction/vulture+/skillless, icon_state="vulture"
  • /obj/item/weapon/gun/lever_action/r4t, icon_state="r4t" & /obj/item/weapon/gun/lever_action, icon_state="r4t-placeholder"
  • /obj/item/weapon/gun/lever_action/xm88, icon_state="boomslang"
  • /obj/item/weapon/gun/pkp, icon_state="qjy72"
  • /obj/item/weapon/gun/revolver/m44/custom/pkd_special+/k2049, icon_state="lapd_2019"
  • /obj/item/weapon/gun/revolver/m44/custom/pkd_special/l_series, icon_state="pkd_double"
  • /obj/item/weapon/gun/revolver/m44/custom/webley, icon_state="webley"
  • /obj/item/weapon/gun/revolver/upp+/shrapnel, icon_state="zhnk72"
  • /obj/item/weapon/gun/shotgun/combat/riot, icon_state="mp220"
  • /obj/item/weapon/gun/shotgun/combat/guard, icon_state="mp221"
  • /obj/item/weapon/gun/shotgun/combat/marsoc, icon_state="mk210"
  • /obj/item/weapon/gun/shotgun/type23+/breacher+/breacher/slug+/breacher/flechette+/dual+/dragon+/riot_control, icon_state="type23"
  • /obj/item/weapon/gun/shotgun/double/twobore, icon_state="twobore"
  • /obj/item/weapon/gun/smartgun/rmc, icon_state="magsg"
  • /obj/item/weapon/gun/smg/pps43+/extended_mag, icon_state="insasu"
  • /obj/item/weapon/gun/smg/bizon, icon_state="type64"
  • /obj/item/weapon/gun/smg/bizon/upp, icon_state="type64_u"
  • /obj/item/weapon/gun/smg/uzi, icon_state="uzi"
  • /obj/item/weapon/gun/smg/nailgun, icon_state="nailgun"
  • /obj/item/weapon/gun/smg/nailgun/compact, icon_state="cnailgun"

I have grouped guns together that either are using the same icon_state (+ to the path) or separate icon_states that likely can just be duplicated in icons/obj/items/weapons/guns/lineart.dmi

The state of the lineart.dmi in the mentioned PR where I duplicated and renamed some existing ones:
image

What's the difference with what should have happened?

Technically we should never display the no_name sprite (If viewing on master before the merge of the mentioned PR it will instead be the 88m4 pistol image as default instead) when viewing this weapon's stats panel; but this is very low priority. I have already excluded from the above list any that are flagged as GUN_UNUSUAL_DESIGN since they cannot be examined in this way.

How do we reproduce this bug?

  1. Equip one of the mentioned guns
  2. Examine it
  3. Click [See combat statistics]
  4. Observe the usage of the no_name sprite (If viewing on master before the merge of the mentioned PR it will instead be the 88m4 pistol image as default instead) e.g.
    image

Issue Bingo
@Drulikar Drulikar added Sprites Remove the soul from the game. Consistency Issue Who needs consistency? Confirmed Bug We have the same at home! labels Feb 16, 2024
@Blundir Blundir mentioned this issue Aug 9, 2024
Merged
@Blundir Blundir linked a pull request Aug 9, 2024 that will close this issue
Adds all missing lineart images in gun examine #6905
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 22, 2024
@Blundir
Adds all missing lineart images in gun examine (#6905)
027781c 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->

# About the pull request

Adds all missing ones mentioned in
#5733, i'll handle some
others and resprites of old ones in another pr.


![ljaipkGMkF](https://github.com/user-attachments/assets/769d8beb-98e0-4689-852b-96c7f4e9e7ef)


All sprites by me.


# Explain why it's good for the game

Missing icons bad

# Testing Photographs and Procedure
<!-- Include any screenshots/videos/debugging steps of the modified code
functioning successfully, ideally including edge cases. -->


<details>
<summary>Screenshots & Videos</summary>


![dreammaker_Xvmf2lXvQS](https://github.com/user-attachments/assets/d63275bd-3012-4dc9-909e-541ec11715c8)


</details>


# Changelog

<!-- If your PR modifies aspects of the game that can be concretely
observed by players or admins you should add a changelog. If your change
does NOT meet this description, remove this section. Be sure to properly
label your changes in the changelog. Please note that maintainers freely
reserve the right to remove and add tags should they deem it
appropriate. You can attempt to finagle the system all you want, but
it's best to shoot for clear communication right off the bat. -->
<!-- If you add a name after the ':cl', that name will be used in the
changelog. You must add your CKEY after the CL if your GitHub name
doesn't match. Maintainers freely reserve the right to remove and add
tags should they deem it appropriate. -->

:cl:
imageadd: adds lineart images for almost all guns that didn't have it
code: missing lineart error is now a lint
/:cl:

<!-- Both :cl:'s are required for the changelog to work! -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug We have the same at home! Consistency Issue Who needs consistency? Sprites Remove the soul from the game.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds all missing lineart images in gun examine Blundir/cmss13
1 participant
@Drulikar