Combine summarize_* filter in surveys aggregation
#1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnrefsmmat
requested changes
Oct 7, 2021
Contributor
capnrefsmmat
left a comment
capnrefsmmat
left a comment
There was a problem hiding this comment.
Good catch (and lol several GB from a single line). I think it can be simplified further though, if it matters
capnrefsmmat
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combine column and row filters in
summarize_indicators_day/summarize_aggregations_groupfunction for small memory improvement (on my machine, minus a few GB at peak memory usage).