Skip to content

Fix hanging survey CI tests #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krivard merged 1 commit into from
Oct 7, 2021
Merged

Fix hanging survey CI tests #1302

krivard merged 1 commit into from
Oct 7, 2021

Conversation

@nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Oct 7, 2021

Description

Import Rcpp more explicitly following this suggestion. Seems like we were implicitly using Rcpp as loaded by lubridate, but after update 1.7.10 -> 1.8.0, lubridate no longer uses Rcpp and our package begins raising weird errors and hanging when trying to run C++ code.

Changelog

  • Add specific Rcpp import to the code calling the C++ function so that Rcpp gets imported in NAMESPACE.

@nmdefries
import Rcpp more explicitly
5b741ec 
since it is no longer loaded by lubridate after update (1.7.10 ->
1.8.0)
@nmdefries nmdefries requested a review from capnrefsmmat October 7, 2021 22:34
capnrefsmmat
capnrefsmmat approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@capnrefsmmat capnrefsmmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird

@krivard krivard merged commit 0de0074 into main Oct 7, 2021
@krivard krivard deleted the fix-hanging-unit-tests branch October 7, 2021 23:19
@krivard krivard mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@capnrefsmmat capnrefsmmat capnrefsmmat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nmdefries @capnrefsmmat @krivard