From e3ba42332db8a91740ddbc50fea1da17dd6ec395 Mon Sep 17 00:00:00 2001 From: QX Teo <37101453+qx-teo@users.noreply.github.com> Date: Tue, 19 Oct 2021 17:28:50 -0400 Subject: [PATCH 1/2] Suppress rapid_change_num_rows Test constantly failing for covid_ag_raw_pct_positive since not all geo_ids have data every day, we suppress errors for this since it's a false positive --- ansible/templates/quidel_covidtest-params-prod.json.j2 | 5 ++++- quidel_covidtest/params.json.template | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/ansible/templates/quidel_covidtest-params-prod.json.j2 b/ansible/templates/quidel_covidtest-params-prod.json.j2 index 8d56d4166..50cf299d0 100644 --- a/ansible/templates/quidel_covidtest-params-prod.json.j2 +++ b/ansible/templates/quidel_covidtest-params-prod.json.j2 @@ -26,7 +26,10 @@ "min_expected_lag": {"all": "5"}, "max_expected_lag": {"all": "5"}, "dry_run": true, - "suppressed_errors": [] + "suppressed_errors": [ + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive"} + ] }, "static": { "minimum_sample_size": 50 diff --git a/quidel_covidtest/params.json.template b/quidel_covidtest/params.json.template index 60174b232..90faedf79 100644 --- a/quidel_covidtest/params.json.template +++ b/quidel_covidtest/params.json.template @@ -27,7 +27,10 @@ "min_expected_lag": {"all": "5"}, "max_expected_lag": {"all": "5"}, "dry_run": true, - "suppressed_errors": [] + "suppressed_errors": [ + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive"} + ] }, "static": { "minimum_sample_size": 50 From 44372613d77d41d6d63560de6f0c7eef3c810525 Mon Sep 17 00:00:00 2001 From: QX Teo <37101453+qx-teo@users.noreply.github.com> Date: Wed, 20 Oct 2021 12:30:19 -0400 Subject: [PATCH 2/2] Add specificity to suppressed error Only suppress errors for smaller geo_types --- ansible/templates/quidel_covidtest-params-prod.json.j2 | 9 ++++++++- quidel_covidtest/params.json.template | 9 ++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/ansible/templates/quidel_covidtest-params-prod.json.j2 b/ansible/templates/quidel_covidtest-params-prod.json.j2 index 50cf299d0..6047b0469 100644 --- a/ansible/templates/quidel_covidtest-params-prod.json.j2 +++ b/ansible/templates/quidel_covidtest-params-prod.json.j2 @@ -28,7 +28,14 @@ "dry_run": true, "suppressed_errors": [ {"check_name": "check_rapid_change_num_rows", - "signal": "covid_ag_raw_pct_positive"} + "signal": "covid_ag_raw_pct_positive", + "geo_type": "hrr"}, + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive", + "geo_type": "msa"}, + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive", + "geo_type": "county"} ] }, "static": { diff --git a/quidel_covidtest/params.json.template b/quidel_covidtest/params.json.template index 90faedf79..49649c9ff 100644 --- a/quidel_covidtest/params.json.template +++ b/quidel_covidtest/params.json.template @@ -29,7 +29,14 @@ "dry_run": true, "suppressed_errors": [ {"check_name": "check_rapid_change_num_rows", - "signal": "covid_ag_raw_pct_positive"} + "signal": "covid_ag_raw_pct_positive", + "geo_type": "hrr"}, + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive", + "geo_type": "msa"}, + {"check_name": "check_rapid_change_num_rows", + "signal": "covid_ag_raw_pct_positive", + "geo_type": "county"} ] }, "static": {