Skip to content

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Oct 19, 2021

Description

See #1319.

Changelog

  • Update source FIPS population source file.
  • Update the dependent crosswalks.
  • Add a sanity check notebook and remove an outdated one.

Fixes

@krivard
Copy link
Contributor

krivard commented Oct 20, 2021

Looks like there are a whole pile of indicator tests that depend on the previous population mappings 😖

Those will need to be updated before we can merge.

@chinandrew
Copy link
Contributor

Looks like there are a whole pile of indicator tests that depend on the previous population mappings confounded

Those will need to be updated before we can merge.

If there's a use case to applying 2020 data to pre Apr 1 (e.g. if someone who isn't doing an as_of analysis believes the 2020 data is more accurate than the 2019 estimates for the true population on January 1, 2021, they're free to use that), we could possibly kill two birds with one stone by changing geomapper so it can be init with a census_year argument where people can specify 2020 or 2019. Then all the broken tests can be set to use 2019 since it's just test data.

@dshemetov
Copy link
Contributor Author

That's an interesting idea, but the tests are written with hard coded population values and functions that don't take a geomapper argument :/

@dshemetov
Copy link
Contributor Author

Do you think we should then keep two directories of crosswalk files? Seems like a nice conservative approach, in case the update breaks something for users.

@dshemetov
Copy link
Contributor Author

Gonna go ahead and just fix the tests for now and open issues for geomapper extensions to support 2019 and 2020 population estimates. We can think about coming up with a cutoff date for when we use the 2019 values vs the 2020 values for prop then.

@dshemetov
Copy link
Contributor Author

Alright, looks like we squashed all the hardcoded prop tests.

Copy link
Contributor

@nmdefries nmdefries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update delphi_utils.geomapper to 2020 FIPS population data

5 participants