Skip to content

Conversation

@chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Jan 3, 2022

Description

See #1388 and #1443

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Add a make install-ci target that installs everything in the standard, noneditable mode. Not sure install-ci is the best naming so open to suggestions.
  • Fix nowcast directory which was missing inits
  • Fix the find/grep statement in the makefile to only return 1 result. If subdirs are present in an indicator, it returns multiple results and causes issues with make test

Fixes

@chinandrew chinandrew requested a review from krivard January 3, 2022 19:40
@chinandrew
Copy link
Contributor Author

chinandrew commented Jan 3, 2022

looks like i gotta fix some nowcast linting which was previously missed, will do that in a separate pr (EDIT: added in #1445)

@chinandrew chinandrew mentioned this pull request Jan 3, 2022
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit ab408fb into main Jan 6, 2022
@krivard krivard deleted the new-ci-make branch January 6, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider updating CI to use nonlocal delphi-utils installation (possibly through a separate make target) -- attn @chinandrew

3 participants