Skip to content

Fix nowcast linting #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

Fix nowcast linting #1445

merged 1 commit into from
Jan 6, 2022

Conversation

@chinandrew
Copy link
Contributor

@chinandrew chinandrew commented Jan 3, 2022

Description

Nowcast folder wasnt being linted properly, which I discovered in #1444. This PR fixes that.

Blocking #1444

Changelog

Itemize code/test/documentation changes and files added/removed.

  • Allow 1 latter capital variables since they are taken from mathematical notation
  • Remove ground_truth.py file which is super old and needs to be rewritten anyway if we want to use it
  • Remove unused imports/variables.

Fixes

  • Fixes #(issue)

@chinandrew chinandrew requested a review from mariajahja January 3, 2022 23:25
@chinandrew chinandrew mentioned this pull request Jan 4, 2022
Merged
mariajahja
mariajahja approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@mariajahja mariajahja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@krivard krivard changed the base branch from main to new-ci-make January 6, 2022 18:20
@krivard krivard merged commit daa52d2 into new-ci-make Jan 6, 2022
@krivard krivard deleted the nowcast-lint branch January 6, 2022 18:20
@krivard krivard mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariajahja mariajahja mariajahja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chinandrew @mariajahja @krivard