Skip to content

Conversation

@nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented Sep 26, 2024

Adds several new datasets that are currently either exported by epipredict or are used in its vignettes (but not exported). The datasets are:

  • archive_cases_dv_subset_all_states
  • case_death_rate_archive_tbl
  • county_smoothed_cli_comparison
  • (a few others were already added in Update data attributions #2)

Saves data to disk using version 2 of save, for compatibility with older versions of R. Changes data variables in data-raw scripts from *_dt to *_tbl. Change the covid_case_death_rates as_of date to match epipredict test expectations. Convert ctis_covid_behaviours to an epi_df.

brookslogan and others added 30 commits June 14, 2023 10:46
Co-authored-by: brookslogan <lcbrooks+github@andrew.cmu.edu>
rename all the underlying data to *_dt

move dates into `local` and use :::
@nmdefries nmdefries force-pushed the ndefries/epipredict-support branch from 849b65f to a42a262 Compare September 26, 2024 22:14
@nmdefries nmdefries marked this pull request as ready for review September 30, 2024 17:12
Base automatically changed from lcb/adjust-attribution to main October 1, 2024 22:08
@nmdefries
Copy link
Collaborator Author

nmdefries commented Oct 2, 2024

Not sure why so much commit history is showing up here. Edit: this seems to be an annoying issue with squash merges. This branch was off of another feature branch. Squash-merging that one to main automatically switched this one to be merged into main, but after the squash merge, it doesn't recognize all of the old commits as shared history.

@nmdefries
Copy link
Collaborator Author

nmdefries commented Oct 3, 2024

Rebasing this is getting really messy, so I'm going to leave the commit history as-is. Commits that aren't on main start from ~c129398

with `.before = Inf`, though simply omitting & relying on default would work as well.
Copy link
Collaborator

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a very minor tweak and files an issue about 7dav and prop signal history off into #9.

@brookslogan brookslogan merged commit 3bb5a82 into main Oct 14, 2024
2 checks passed
@brookslogan brookslogan deleted the ndefries/epipredict-support branch October 14, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants