From 156c7282fe8004e9fdbd05b233747050c7f5b8df Mon Sep 17 00:00:00 2001 From: dsweber2 Date: Thu, 7 Nov 2024 17:23:17 -0600 Subject: [PATCH 1/3] patch drop_ignored_keys broken grouped behavior --- R/utils-latency.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/utils-latency.R b/R/utils-latency.R index 8bcd2b1e..25799f22 100644 --- a/R/utils-latency.R +++ b/R/utils-latency.R @@ -358,7 +358,7 @@ get_latency_table <- function(training, columns, forecast_date, latency, drop_ignored_keys <- function(training, keys_to_ignore) { # note that the extra parenthesis black magic is described here: https://github.com/tidyverse/dplyr/issues/6194 # and is needed to bypass an incomplete port of `across` functions to `if_any` - training %>% + training %>% ungroup %>% filter((dplyr::if_all( names(keys_to_ignore), ~ . %nin% keys_to_ignore[[cur_column()]] From a92f0767917539a7b68242a293df5303eaf083ed Mon Sep 17 00:00:00 2001 From: dsweber2 Date: Thu, 7 Nov 2024 17:25:40 -0600 Subject: [PATCH 2/3] bump version --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 2ae9d333..456cdb54 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: epipredict Title: Basic epidemiology forecasting methods -Version: 0.1.3 +Version: 0.1.4 Authors@R: c( person("Daniel J.", "McDonald", , "daniel@stat.ubc.ca", role = c("aut", "cre")), person("Ryan", "Tibshirani", , "ryantibs@cmu.edu", role = "aut"), From 265468789ac607bb9716e51d5285ed9087b4685c Mon Sep 17 00:00:00 2001 From: dsweber2 Date: Thu, 7 Nov 2024 17:28:58 -0600 Subject: [PATCH 3/3] formatting --- R/utils-latency.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/utils-latency.R b/R/utils-latency.R index 25799f22..d854cb9c 100644 --- a/R/utils-latency.R +++ b/R/utils-latency.R @@ -358,7 +358,8 @@ get_latency_table <- function(training, columns, forecast_date, latency, drop_ignored_keys <- function(training, keys_to_ignore) { # note that the extra parenthesis black magic is described here: https://github.com/tidyverse/dplyr/issues/6194 # and is needed to bypass an incomplete port of `across` functions to `if_any` - training %>% ungroup %>% + training %>% + ungroup() %>% filter((dplyr::if_all( names(keys_to_ignore), ~ . %nin% keys_to_ignore[[cur_column()]]