From a332bd3c86a2bf4aed9810e300cac3775be525dc Mon Sep 17 00:00:00 2001
From: Nat DeFries <42820733+nmdefries@users.noreply.github.com>
Date: Wed, 21 Feb 2024 12:04:44 -0500
Subject: [PATCH 1/3] suppress across warning about deprecated ...

---
 app.R | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app.R b/app.R
index 4a32f4f..26ad532 100644
--- a/app.R
+++ b/app.R
@@ -57,7 +57,7 @@ load_forecast_data <- memoise::memoise(load_forecast_data_raw, cache = cache)
 prepare_forecaster_table <- function(selected_forecasters) {
   forecasters <- tar_read(forecaster_params_grid) %>%
     select(-id) %>%
-    mutate(across(where(is.list), map, `%||%`, c(0, 7, 14))) %>%
+    mutate(across(where(is.list), function(x) { map(x, `%||%`, c(0, 7, 14)) })) %>%
     mutate(lags = paste(lags, sep = ",")) %>%
     group_by(parent_id) %>%
     mutate(ahead = toString(unique(ahead))) %>%

From a141e5c11774949776c83126d1fb069a5812f8bb Mon Sep 17 00:00:00 2001
From: Nat DeFries <42820733+nmdefries@users.noreply.github.com>
Date: Wed, 21 Feb 2024 13:15:31 -0500
Subject: [PATCH 2/3] add button to filter aheads/geos on command by removing
 auto-dependency on them

---
 app.R | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/app.R b/app.R
index 26ad532..7560406 100644
--- a/app.R
+++ b/app.R
@@ -164,7 +164,8 @@ shinyApp(
             "Exclude aheads:",
             choices = 1:28,
             multiple = TRUE
-          )
+          ),
+          actionButton("submit_exclusions", "Apply exclusions")
         ),
         mainPanel(
           verticalLayout(
@@ -181,7 +182,15 @@ shinyApp(
     )
   },
   server = function(input, output, session) {
-    filtered_scorecards_reactive <- reactive({
+    EXCLUDED_GEO_VALUES <- reactive({
+      input$submit_exclusions # Take a dependency on
+      isolate(input$excluded_geo_values) # Prevent from taking a dependency on
+    })
+    EXCLUDED_AHEADS <- reactive({
+      input$submit_exclusions # Take a dependency on
+      isolate(input$excluded_aheads) # Prevent from taking a dependency on
+    })
+    FILTERED_SCORECARDS_REACTIVE <- reactive({
       agg_forecasters <- unique(c(input$selected_forecasters, input$baseline))
       if (length(agg_forecasters) == 0 ||
         all(agg_forecasters == "" | is.null(agg_forecasters) | is.na(agg_forecasters))
@@ -194,14 +203,15 @@ shinyApp(
           filter(
             .data$forecast_date %>>% between(.env$input$selected_forecast_date_range[[1L]], .env$input$selected_forecast_date_range[[2L]]),
             .data$target_end_date %>>% between(.env$input$selected_target_end_date_range[[1L]], .env$input$selected_target_end_date_range[[2L]]),
-            !.data$geo_value %in% c(.env$input$excluded_geo_values, "us"),
-            !.data$ahead %in% .env$input$excluded_aheads
+            !.data$geo_value %in% c(EXCLUDED_GEO_VALUES(), "us"),
+            !.data$ahead %in% EXCLUDED_AHEADS()
           )
       }) %>%
         bind_rows()
     })
+
     output$main_plot <- renderPlotly({
-      input_df <- filtered_scorecards_reactive()
+      input_df <- FILTERED_SCORECARDS_REACTIVE()
       if (nrow(input_df) == 0) {
         return()
       }
@@ -266,7 +276,7 @@ shinyApp(
             # points smaller.
             scale_factor_fcast <- length(input$selected_forecasters) * 2
             scale_factor_facet <- length(input$facet_vars) * 5
-            scale_factor_geo <- ("geo_value" %in% input$facet_vars) * (60 - length(input$excluded_geo_values))
+            scale_factor_geo <- ("geo_value" %in% input$facet_vars) * (60 - length(EXCLUDED_GEO_VALUES()))
             scale_factor_geo_x <- ("geo_value" %in% input$x_var) * 10
             scale_factor_facet_fcast <- ifelse("forecaster" %in% input$facet_vars, length(input$selected_forecasters), 0) * 5
             scale_factor <- scale_factor_geo + scale_factor_geo_x + scale_factor_fcast + scale_factor_facet + scale_factor_facet_fcast

From 7a7e4db07b4339e7509fd6487867388f1f34ac2a Mon Sep 17 00:00:00 2001
From: Nat DeFries <42820733+nmdefries@users.noreply.github.com>
Date: Wed, 21 Feb 2024 13:20:07 -0500
Subject: [PATCH 3/3] button name

---
 app.R | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app.R b/app.R
index 7560406..b0bee5a 100644
--- a/app.R
+++ b/app.R
@@ -165,7 +165,7 @@ shinyApp(
             choices = 1:28,
             multiple = TRUE
           ),
-          actionButton("submit_exclusions", "Apply exclusions")
+          actionButton("apply_exclusions", "Apply exclusions")
         ),
         mainPanel(
           verticalLayout(
@@ -183,11 +183,11 @@ shinyApp(
   },
   server = function(input, output, session) {
     EXCLUDED_GEO_VALUES <- reactive({
-      input$submit_exclusions # Take a dependency on
+      input$apply_exclusions # Take a dependency on
       isolate(input$excluded_geo_values) # Prevent from taking a dependency on
     })
     EXCLUDED_AHEADS <- reactive({
-      input$submit_exclusions # Take a dependency on
+      input$apply_exclusions # Take a dependency on
       isolate(input$excluded_aheads) # Prevent from taking a dependency on
     })
     FILTERED_SCORECARDS_REACTIVE <- reactive({