Explicitly pick out used columns #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateharwood
approved these changes
Apr 6, 2021
|
|
||
| # Pick out expected columns only | ||
| covCols = paste0("cov_", COVERAGE_INTERVALS) | ||
| expectedCols = c("ahead", "geo_value", "forecaster", "forecast_date", |
There was a problem hiding this comment.
Worth noting that we don't use all of these columns when processing the data later on (for instance, we don't need "data_source", and we don't currently use "forecast_date"), but might still be a good idea to keep them in, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon loading RDS files downloaded from the S3 bucket, explicitly picks out the expected columns from each RDS file before the rbind.
Addresses #102, in case
evalcastproduces extra unexpected columns for any of the RDS files again.