Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search icon and na hint #525

Merged
merged 3 commits into from Oct 14, 2020
Merged

search icon and na hint #525

merged 3 commits into from Oct 14, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Sep 30, 2020

closes #519 and closes #516

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

search and clear icon should be shown consistently:
image

NA legend hint:

image

image

@sgratzl sgratzl added this to In Review/Testing in COVIDCast Ongoing Development Sep 30, 2020
@adamperer adamperer assigned tildechris and unassigned adamperer Oct 5, 2020
@adamperer adamperer removed their request for review October 5, 2020 17:06
@netlify
Copy link

netlify bot commented Oct 13, 2020

Preview link ready!

Built with commit 4b784a7

https://deploy-preview-525--cmu-delphi-covidcast.netlify.app

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tildechris tildechris merged commit 74dd775 into dev Oct 14, 2020
COVIDCast Ongoing Development automation moved this from In Review/Testing to Done Oct 14, 2020
@tildechris tildechris deleted the sgratzl/searchstyle branch October 14, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

search icon / remove icon not visible on mobile add NA legend marker to bubble/spike legends
3 participants