Skip to content

Conversation

@Raphael-Hyde
Copy link
Contributor

  1. Decreased text size on landing, about and team pages.
  2. Replaced hero image on about page
  3. Added media query to reduce text size and image on mobile view.
  4. Added margin and padding to allow text to breath.

@netlify
Copy link

netlify bot commented Nov 24, 2020

Deploy preview for cmu-delphi-main ready!

Built with commit 8cf3a9e

https://deploy-preview-112--cmu-delphi-main.netlify.app

@Raphael-Hyde
Copy link
Contributor Author

I've made the recommended changes, thanks Sam!

Copy link
Member

@sgratzl sgratzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code wise

Also, remvoed the collaborator logos and swapped in a UL list of them.
@Raphael-Hyde
Copy link
Contributor Author

@tildechris let me know what you think of the updates to the About page :) thanks!

@tildechris
Copy link
Contributor

@Letsgohyde this looks great. I made a change to the responsive layout and height of the image and merged in from dev because you also changed the collaborators section.

@tildechris tildechris requested a review from sgratzl November 25, 2020 18:23
@tildechris
Copy link
Contributor

Sam, I addressed your feedback items. Please, take a look.

@tildechris tildechris requested a review from sgratzl November 25, 2020 20:01
@tildechris
Copy link
Contributor

Merging in order to make release branch.

@tildechris tildechris merged commit d0c535f into dev Nov 25, 2020
@tildechris tildechris deleted the letsgohyde-v1-density-changes branch November 25, 2020 21:08
@tildechris tildechris mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants