Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider semiring in ewise* interface as an argument #38

Closed
paldar opened this issue May 24, 2016 · 3 comments
Closed

consider semiring in ewise* interface as an argument #38

paldar opened this issue May 24, 2016 · 3 comments

Comments

@paldar
Copy link
Collaborator

paldar commented May 24, 2016

No description provided.

@mcmillan03
Copy link
Collaborator

To clarify, these funtions only need BinaryFunction's to operate (structural zeros are never accessed or produced in these operations). We can provide both BinaryFunction and Monoid objects unambiguously. Should we support a signature that takes a Semiring then implicit logic should be document or explicit parameter must be supported to say which Monoid or BinaryFunction within the Semiring should be use. The obvious implicit logic is for eWiseAdd to access the additive Monoid and eWiseMult to access the multiplicative Monoid/BinaryFunction.

@mcmillan03
Copy link
Collaborator

Accidentally closed.

@mcmillan03
Copy link
Collaborator

The correct way is to wrap the semiring in a "view" object that adheres to the BinaryFunction concept. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants