Browse files

Removed spurious io:format

  • Loading branch information...
1 parent d756a2b commit 7958fc2f6b141759c5a046bbf7fa647e1ca115cc Chandrashekhar Mullaparthi committed Sep 24, 2010
Showing with 42 additions and 37 deletions.
  1. +37 −22 README
  2. +2 −2 doc/ibrowse.html
  3. +1 −1 ebin/ibrowse.app
  4. +1 −2 src/ibrowse.erl
  5. +0 −9 src/ibrowse_http_client.erl
  6. +1 −1 vsn.mk
View
59 README
@@ -18,31 +18,46 @@ ibrowse is available under two different licenses. LGPL or the BSD license.
Comments to : Chandrashekhar.Mullaparthi@gmail.com
-Version : 2.0.0
+Version : 2.0.1
Latest version : git://github.com/cmullaparthi/ibrowse.git
CONTRIBUTIONS & CHANGE HISTORY
==============================
-22-09-2010 - * Added option preserve_chunked_encoding. This allows the caller to get
- the raw HTTP response when the Transfer-Encoding is Chunked. This feature
- was requested by Benoit Chesneau who wanted to write a HTTP proxy using
- ibrowse.
- * Fixed bug with the {stream_to, {Pid, once}} option. Bug report and lot
- of help from Filipe David Manana. Thank you Filipe.
- * The {error, conn_failed} and {error, send_failed} return values are
- now of the form {error, {conn_failed, Err}} and
- {error, {send_failed, Err}}. This is so that the specific socket error
- can be returned to the caller. I think it looks a bit ugly, but that
- is the best compromise I could come up with.
- * Added application configuration parameters default_max_sessions and
- default_max_pipeline_size. These were previously hard coded to 10.
- * Versioning of ibrowse now follows the Semantic Versioning principles.
- See http://semver.org. Thanks to Anthony Molinaro for nudging me in
- this direction.
- * The connect_timeout option now only applies to the connection setup
- phase. In previous versions, the time taken to setup the connection
- was deducted from the specified timeout value for the request.
+24-09-2010 - v2.0.1
+ * Removed a spurious io:format statement
+
+22-09-2010 - v2.0.0.
+
+ * Added option preserve_chunked_encoding. This allows the
+ caller to get the raw HTTP response when the
+ Transfer-Encoding is Chunked. This feature was requested
+ by Benoit Chesneau who wanted to write a HTTP proxy using
+ ibrowse.
+
+ * Fixed bug with the {stream_to, {Pid, once}} option. Bug
+ report and lot of help from Filipe David Manana. Thank
+ you Filipe.
+
+ * The {error, conn_failed} and {error, send_failed} return
+ values are now of the form {error, {conn_failed, Err}}
+ and {error, {send_failed, Err}}. This is so that the
+ specific socket error can be returned to the caller. I
+ think it looks a bit ugly, but that is the best
+ compromise I could come up with.
+
+ * Added application configuration parameters
+ default_max_sessions and default_max_pipeline_size. These
+ were previously hard coded to 10.
+
+ * Versioning of ibrowse now follows the Semantic Versioning
+ principles. See http://semver.org. Thanks to Anthony
+ Molinaro for nudging me in this direction.
+
+ * The connect_timeout option now only applies to the
+ connection setup phase. In previous versions, the time
+ taken to setup the connection was deducted from the
+ specified timeout value for the request.
17-07-2010 - * Merged change made by Filipe David Manana to use the base64
module for encoding/decoding.
@@ -173,7 +188,7 @@ CONTRIBUTIONS & CHANGE HISTORY
12-01-2007 - Derek Upham sent in a bug fix. The reset_state function was not
behaving correctly when the transfer encoding was not chunked.
-13-11-2006 - Youns Hafri reported a bug where ibrowse was not returning the
+13-11-2006 - Youns Hafri reported a bug where ibrowse was not returning the
temporary filename when the server was closing the connection
after sending the data (as in HTTP/1.0).
Released ibrowse under the BSD license
@@ -192,7 +207,7 @@ CONTRIBUTIONS & CHANGE HISTORY
22-Nov-2005 - Added ability to generate requests using the Chunked
Transfer-Encoding.
-08-May-2005 - Youns Hafri made a CRUX LINUX port of ibrowse.
+08-May-2005 - Youns Hafri made a CRUX LINUX port of ibrowse.
http://yhafri.club.fr/crux/index.html
Here are some usage examples. Enjoy!
View
4 doc/ibrowse.html
@@ -12,7 +12,7 @@
<ul class="index"><li><a href="#description">Description</a></li><li><a href="#index">Function Index</a></li><li><a href="#functions">Function Details</a></li></ul>The ibrowse application implements an HTTP 1.1 client.
<p>Copyright © 2005-2010 Chandrashekhar Mullaparthi</p>
-<p><b>Version:</b> 2.0.0</p>
+<p><b>Version:</b> 2.0.1</p>
<p><b>Behaviours:</b> <a href="gen_server.html"><tt>gen_server</tt></a>.</p>
<p><b>Authors:</b> Chandrashekhar Mullaparthi (<a href="mailto:chandrashekhar dot mullaparthi at gmail dot com"><tt>chandrashekhar dot mullaparthi at gmail dot com</tt></a>).</p>
@@ -446,6 +446,6 @@ <h3 class="function"><a name="trace_on-2">trace_on/2</a></h3>
<hr>
<div class="navbar"><a name="#navbar_bottom"></a><table width="100%" border="0" cellspacing="0" cellpadding="2" summary="navigation bar"><tr><td><a href="overview-summary.html" target="overviewFrame">Overview</a></td><td><a href="http://www.erlang.org/"><img src="erlang.png" align="right" border="0" alt="erlang logo"></a></td></tr></table></div>
-<p><i>Generated by EDoc, Sep 22 2010, 22:56:44.</i></p>
+<p><i>Generated by EDoc, Sep 24 2010, 06:42:36.</i></p>
</body>
</html>
View
2 ebin/ibrowse.app
@@ -1,6 +1,6 @@
{application, ibrowse,
[{description, "HTTP client application"},
- {vsn, "1.6.2"},
+ {vsn, "2.0.0"},
{modules, [ ibrowse,
ibrowse_http_client,
ibrowse_app,
View
3 src/ibrowse.erl
@@ -7,7 +7,7 @@
%%%-------------------------------------------------------------------
%% @author Chandrashekhar Mullaparthi <chandrashekhar dot mullaparthi at gmail dot com>
%% @copyright 2005-2010 Chandrashekhar Mullaparthi
-%% @version 2.0.0
+%% @version 2.0.1
%% @doc The ibrowse application implements an HTTP 1.1 client. This
%% module implements the API of the HTTP client. There is one named
%% process called 'ibrowse' which assists in load balancing and maintaining configuration. There is one load balancing process per unique webserver. There is
@@ -334,7 +334,6 @@ try_routing_request(Lb_pid, Parsed_url,
case do_send_req(Conn_Pid, Parsed_url, Headers,
Method, Body, Options_1, Timeout) of
{error, sel_conn_closed} ->
- io:format("Selected connection closed. Trying again...~n", []),
try_routing_request(Lb_pid, Parsed_url,
Max_sessions,
Max_pipeline_size,
View
9 src/ibrowse_http_client.erl
@@ -305,12 +305,10 @@ handle_sock_data(Data, #state{status = get_body,
{stop, normal, State};
#state{cur_req = #request{caller_controls_socket = Ccs},
interim_reply_sent = Irs} = State_1 ->
- %% io:format("Irs: ~p~n", [Irs]),
case Irs of
true ->
active_once(State_1);
false when Ccs == true ->
- %% io:format("Setting {active,once}~n", []),
do_setopts(Socket, [{active, once}], State);
false ->
active_once(State_1)
@@ -1168,13 +1166,6 @@ parse_11_response(DataRecvd,
{RemChunk, RemData} = split_binary(DataRecvd, NeedBytes),
do_trace("Recvd another chunk...~p~n", [RemChunk]),
do_trace("RemData -> ~p~n", [RemData]),
- case RemData of
- <<>> ->
- %% io:format("RemData -> ~p~n", [RemData]);
- ok;
- _ ->
- ok
- end,
case accumulate_response(RemChunk, State) of
{error, Reason} ->
do_trace("Error accumulating response --> ~p~n", [Reason]),
View
2 vsn.mk
@@ -1,2 +1,2 @@
-IBROWSE_VSN = 2.0.0
+IBROWSE_VSN = 2.0.1

2 comments on commit 7958fc2

@fdmanana

Hi again Chandru,

Shouldn't ebin/ibrowse.app be in the ignore list (not versioned) ?

cheers

@cmullaparthi

Yes, I agree. I had known about this for a while. Will probably take it out at the next update.

Please sign in to comment.