[regression] ibrowse_lib:parse_url/1 error on ipv6 hostnames #64

Closed
helllamer opened this Issue Mar 12, 2012 · 2 comments

Comments

Projects
None yet
2 participants

After recent update, parse_url() became unable to properly parse ipv6 as hostname:

1> ibrowse_lib:parse_url("http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html").
{error,invalid_uri}

2> ibrowse_lib:parse_url("http://[1080:0:0:0:8:800:200C:417A]/index.html").                
{error,invalid_uri}

3> ibrowse_lib:parse_url("http://[::192.9.5.5]/ipng").                     
{error,invalid_uri}

Example URLs is taken from http://www.ietf.org/rfc/rfc2732.txt

Regression is not reproduceable before this commit: 26d34d5

Ok, fixed. Please review and merge.

@helllamer helllamer added a commit to helllamer/ibrowse that referenced this issue Mar 12, 2012

@helllamer helllamer argghhh! fix identation s/tab/spaces/ #64
/
f08160c
Owner

cmullaparthi commented Mar 13, 2012

Thank you for the report and the patch. I've added it and also added some test cases so that this regression doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment