Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite relocation to be compliant with P1144 #67

Merged
merged 11 commits into from
Feb 17, 2024
Merged

Conversation

DanielLiamAnderson
Copy link
Contributor

Relocation now mostly follows the API proposed in P1144. Parlay will also defer the implementation of relocation operations to the compiler/library if they are present, which currently works on Arthur O'Dwyer's LLVM fork here.

@DanielLiamAnderson DanielLiamAnderson marked this pull request as draft November 26, 2023 03:58
@DanielLiamAnderson DanielLiamAnderson self-assigned this Nov 26, 2023
@DanielLiamAnderson DanielLiamAnderson added the enhancement New feature or request label Nov 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9e60787) 96.91% compared to head (3aee6d2) 96.80%.
Report is 1 commits behind head on master.

Files Patch % Lines
include/parlay/internal/integer_sort.h 66.66% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   96.91%   96.80%   -0.12%     
==========================================
  Files          56       57       +1     
  Lines        3701     3719      +18     
==========================================
+ Hits         3587     3600      +13     
- Misses        114      119       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Quuxplusone
Copy link

@DanielLiamAnderson belated ping! The deadline for P1144R10 is early on February 15th — any chance this PR could be merged by then?

@DanielLiamAnderson
Copy link
Contributor Author

Oops, yes, I'll try! I just want to finish a little more testing but I'll see if I can do that asap.

@DanielLiamAnderson DanielLiamAnderson marked this pull request as ready for review February 17, 2024 03:18
@DanielLiamAnderson DanielLiamAnderson merged commit 36459f4 into master Feb 17, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants