Use correct format for playing 24-bit files with op/oss #614
Conversation
| #define AFMT_S24_BE 0x00020000 | ||
| #endif | ||
| #ifndef AFMT_U24_LE | ||
| #define AFMT_U24_LE 0x00040000 |
There was a problem hiding this comment.
This seems rather dubious. Why was this constant S24_PACKED before?
There was a problem hiding this comment.
I was under the impression that the constants are the same across different OSS implementation, but that's apparently not true. S24_PACKED isn't even defined on FreeBSD and U24_LE isn't defined in OSSv4.
I don't really understand why the constants need to be added here at all to be honest. I've amended the patch a little.
| } else { | ||
| tmp = AFMT_U8; | ||
| found = 0; | ||
| for (i = 0; i < sizeof(oss_fmts)/sizeof(oss_fmts[0]); i++) { |
There was a problem hiding this comment.
There is a macro for this in utils.h
|
This seems to remove support for OSSv3 which requires some justification. |
|
That wasn't my intent. On what system do you see problems? |
|
Adding support for AFMT_{S24,U24}_{LE,BE} will make the format
selection even more difficult to read, so while here replace it with a
simple lookup table.
Tested on FreeBSD.
|
I've re-added the constant-definining-block under an |
|
I'll merge this for now. If anyone still uses OSS, we'll deal with breakage when it happens. |
Adding support for AFMT_{S24,U24}_{LE,BE} will make the format
selection even more difficult to read, so while here replace it with a
simple lookup table.
Tested on FreeBSD. The symptoms of using the wrong format were
the same as with the sndio plugin (#613).