New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating widgets break when dragged off screen in IE 10 #379

Closed
roemhildtg opened this Issue Feb 12, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@roemhildtg
Copy link
Member

roemhildtg commented Feb 12, 2015

Hey there, I like the new addition of dragging the title panes around. That is a nice ui enhancement. One issue I noticed is if you click the 'detach' arrow and then try to drag the widget left off the screen, it gets 'stuck' to the mouse and after the button is released it still gets 'dragged around.

This is only happening in IE 10 to my knowledge, and isn't really that big of a deal as I'm not sure many people will try to drag widgets out of the window.

@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Feb 12, 2015

@roemhildtg Thanks for reporting this. I can confirm that it is occurring for me in IE 11 as well as IE 10. The odd part is that it appears to work without issue in IE9.

We use dojo/dnd (drag and drop) to detect the movement of the window while dragging. I tried debugging this and noticed that the onMoveStop is not being triggered so code that should run after the window stops moving does not run. Not sure if this is a bug in dojo/dnd or if I missed something when coding this functionality. I will dig further...

@DavidSpriggs DavidSpriggs added the bug label Apr 21, 2015

@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Jul 15, 2015

This was addressed in PR #409

@tmcgee tmcgee closed this Jul 15, 2015

@kcsgisRham

This comment has been minimized.

Copy link

kcsgisRham commented Sep 15, 2015

@tmcgee This problem seems to be persisting in IE 10 and 11 on Windows 7, 8 and 10 and also in the new Microsoft Edge. I have added the code from PR#405 to my project and we are still experiencing the same issue. Also, it is happening in the CMV demo site. I have downloaded the develop branch and it is not working.

It works as expected in Firefox and Chrome.

@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Sep 15, 2015

Hmmm. Thanks for posting this. I see what you mean. This was tested with IE10 and IE11 at the time and worked. Looks like something got borked between then and now.

@tmcgee tmcgee reopened this Sep 15, 2015

@tmcgee tmcgee added this to the v1.4.0 milestone Nov 23, 2015

@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Jan 27, 2016

@cmv/core-committers and everyone else: Can somebody else take a look at this issue? I've tried a couple of times and did not find a solution. Some fresh eyes would be helpful. Thanks in advance for any and all assistance provided.

@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Mar 26, 2016

I think I have finally discovered the problem here. Internet Explorer does not like a delay greater than zero for the dnd movable. Setting the delay to zero or omitting it completely solves the problem but causes a few other minor ones. I am reworking the code based on this discovery...

@cmccullough2

This comment has been minimized.

Copy link

cmccullough2 commented Apr 1, 2016

Thank you for catching this issue. I just created a new issue that is the same as this. I did not see this post. I look forward to your update.

tmcgee added a commit that referenced this issue Apr 2, 2016

Adds the ability to resize a floating titlePane widget.
Fixes #379 - mouse does not release after dragging a floating widge when using IE.
The delay before a titlePane starts dragging from the side pane is now configurable.
@tmcgee

This comment has been minimized.

Copy link
Member

tmcgee commented Apr 3, 2016

Fixed as part of PR #530

@tmcgee tmcgee closed this Apr 3, 2016

tmcgee added a commit that referenced this issue Oct 5, 2016

this removes the use of our own (unreliable) drag delay for floating …
…windows.

dojo included with ESRI JS API 3.17+ adds detection for MS Edge browser so
we can use that as a more reliable approach to solving the original issue #379
with dragging floating windows in Internet Explorer and Edge browsers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment