Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix broken pane toggle #613
left a comment
Good catch! This approach (accepting arbitrary input and toggling if it isn't something we recognize) should conflate the last two else if/else conditions since they are logically identical.
Alternatively, to keep the strict togglePane API which only accepts reasonable 'show' arguments I would suggest instead changing line 182 from
Either technically works, I leave the choice of which approach is preferred up to the maintainers.