New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix titlePane issue effecting IE 11/M.S. Edge and now Chrome v 55 #622

Merged
merged 2 commits into from Oct 31, 2016

Conversation

Projects
None yet
2 participants
@tmcgee
Copy link
Member

tmcgee commented Oct 31, 2016

With Chrome version 55 (in the Chrome beta and dev channels), a floating titlePane widget does not stop dragging when the mouse is released. This is the same behavior previously experienced in IE 11 and MS Edge. Version 55 is expected to be released to the Chrome stable channel on December 6th.

I believe the issue is related to this dojo bug. Based on that report, this PR overrides the onMouseUp in dojo Mover class. The fix has been tested with the effected browser versions as well as Firefox.

fix issue in dojo mover class causing IE and now Chrome v 55 to not l…
…et go of the titlePane when mouse is released.

@tmcgee tmcgee added the bug label Oct 31, 2016

@tmcgee tmcgee added this to the v2.0.0-beta.1 milestone Oct 31, 2016

@DavidSpriggs

This comment has been minimized.

Copy link
Member

DavidSpriggs commented Oct 31, 2016

@tmcgee Nice work! Thanks for being on top of this one!

@DavidSpriggs DavidSpriggs merged commit 5d79b34 into develop Oct 31, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@DavidSpriggs DavidSpriggs deleted the fix/floating-titlepane-chrome-55 branch Oct 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment