New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds 3 new widget types: loading, layout and layer. #643

Merged
merged 2 commits into from Dec 5, 2016

Conversation

Projects
None yet
3 participants
@tmcgee
Copy link
Member

tmcgee commented Dec 4, 2016

Also adds 3 new entry points within the Controller to manage when widgets can be created.
Also includes a change to uses the widget's key internally when no id is available. Some Esri widgets cannot have an id passed in the config.

  1. loading widgets are created as early as possible - just after the config file is loaded. Example might be a progress bar.

  2. layout widgets are created after the layout is built but prior to panes being created and the map is loaded. Example: adjust the layout before any contents are added. Not sure of the usefulness of this type. Open for discussion.

  3. layer widgets (and map widgets) created after the map and layers have been loaded but prior to panes being created and before other widgets are loaded. Example: setting the definition expression for a feature layer. Similar in concept to a layer load event but easier to compartmentalize and manage the code as a widget.

adds 3 new widget types: loading, layout and layer.
adds 3 new entry points within the Controller when widgets can be created.
use the widget's key internally when no id is available
@DavidSpriggs

This comment has been minimized.

Copy link
Member

DavidSpriggs commented Dec 5, 2016

Flexibility is always good. Documentation will be key.

@DavidSpriggs DavidSpriggs merged commit 177882d into develop Dec 5, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@DavidSpriggs DavidSpriggs deleted the feature/new-widget-types branch Dec 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment