Fix/review and test suite#3
Merged
Merged
Conversation
replace() now re-applies config.extra_vendors after building the new host map, so background registry refreshes no longer silently drop custom vendor tracking. Also guards against config.extra_vendors = nil in send_batch (was NoMethodError on .empty?). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tests for Configuration defaults, VendorRegistry.load_extra_vendors thread safety, replace() re-applying extra_vendors after refresh, and Collector#send_batch payload inclusion/omission. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.